Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooked job deletion incompatible with Helm --wait and FluxCD by default #100

Open
alee792 opened this issue Jan 19, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@alee792
Copy link
Contributor

alee792 commented Jan 19, 2024

The issues described in this comment will manifest automatically when using FluxCD to manage helmreleases. FluxCD waits by default, and the HelmRelease resource needs spec.upgrade.disableWait: true set for the OpenFGA Helm chart to continue functioning. Without it, the job is deleted before the deployment can check the job.

I don't have any suggestions for how to effectively delete/recreate the job, but figured I'd at least create the issue in case others are using FluxCD and are stumped.

@tamalsaha
Copy link
Contributor

The migrate hook never runs because the openfga pods wait for the migrate job to complete when --wait flag is used. Here is a similar issue: fluxcd/flux2#1085 (comment)

I think one way to solve this will be:

  • Don't use hook to run the migrate job.
  • Increase the timeout and backoffLimit of the migrate job so it waits and retries until the db pods are ready.

I have done this in my fork and it works. Let me know if openfga interested in a pr.

@alee792
Copy link
Contributor Author

alee792 commented May 1, 2024

My experience with the team is that they're very open and responsive to contributions! If you put it up for a PR, I'll help promote and review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants