Incorrect interpretation of x-ratelimit-reset for Okta

[morganfogg]

Checklist

• I have looked into the README and have not found a suitable solution or answer.
• I have looked into the documentation and have not found a suitable solution or answer.
• I have searched the issues and have not found a suitable solution or answer.
• I have upgraded to the latest version of OpenFGA and the issue still persists.
• I have searched the Slack community and have not found a suitable solution or answer.
• I agree to the terms within the OpenFGA Code of Conduct.

Description

Currently the rate-limit handling code interprets the contents of the x-ratelimit-reset header as a number of milliseconds from the current time to wait. (see:

dotnet-sdk/src/OpenFga.Sdk/Exceptions/Parsers/RateLimitParser.cs

Line 96 in 02bbc98

ResetInMs = reset,

However, the x-ratelimit-reset value being returned by Okta FGA is a Unix timestamp rather than an offset from the current time, meaning hitting the rate limit will theoretically cause the code to hang for ~20 days. Further down it also seems to interpret it as either a number of seconds or minutes from the current time, though this property doesn't seem to be used in the delay. An example of the headers I am receiving are:

X-Ratelimit-Limit: 30
X-Ratelimit-Remaining: 0
X-Ratelimit-Reset: 1725235793

Expectation

The SDK interprets the rate limit reset header as a Unix timestamp, or provides an option to do so.

Reproduction

1. Perform a large number of requests against the endpoint https://api.au1.fga.dev
2. SDK hangs indefinitely after the rate limit is hit.

OpenFGA SDK version

0.5.0

OpenFGA version

N/A

SDK Configuration

ApiUrl, StoreId, AuthorizationModelId and Credentials are provided. No other configuration.

Logs

No response

References

The header is interpreted as a number of milliseconds from the current time here:

dotnet-sdk/src/OpenFga.Sdk/Exceptions/Parsers/RateLimitParser.cs

Line 96 in 02bbc98

ResetInMs = reset,

And the delay happens here:

dotnet-sdk/src/OpenFga.Sdk/ApiClient/ApiClient.cs

Line 129 in 02bbc98

await Task.Delay(waitInMs);