Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pull request] Option to include ungraded subsections in progress page #359

Open
navinkarkera opened this issue May 28, 2024 · 6 comments
Open
Assignees
Labels
product review complete PR has gone through product review

Comments

@navinkarkera
Copy link

navinkarkera commented May 28, 2024

Abstract

The legacy progress page had an option to display ungraded subsections which is missing from the new learning MFE. So to keep feature parity with legacy, we have created a PR: openedx/frontend-app-learning#1380 to add it. It can be enabled by setting a flag in MFE_CONFIG.

Milestones and/or Epics

PR: openedx/frontend-app-learning#1380

Named Release

Redwood

Proposed By

OpenCraft

Additional Info

Copy link

Thanks for your submission, @openedx/open-edx-project-managers will review shortly.

@navinkarkera navinkarkera changed the title Option to include ungraded subsections in progress page [Pull request] Option to include ungraded subsections in progress page May 28, 2024
@ali-hugo ali-hugo assigned ali-hugo and unassigned ali-hugo Jun 4, 2024
@ali-hugo ali-hugo added the product review complete PR has gone through product review label Jun 11, 2024
@ali-hugo
Copy link

@itsjeyd The product review for this PR is complete. I've changed the label to indicate as much, but am unsure which column to place this ticket into. Should it go into "backlog" now?

@itsjeyd
Copy link

itsjeyd commented Jun 11, 2024

@ali-hugo Since this is a feature ticket (and not a PR on the Contributions board), that's a question for @jmakowski1123, or perhaps the product working group as a whole 🙂

Updating tickets on the roadmap is out of scope for OSPR managers, and I'm not sure that I know the latest on how the different board columns are supposed to be used. That said, based on a brief look it seems like Being Developed would be a good fit? (We already have a PR with code changes for this feature.)

Either way, I'll take care of updating the PR that belongs to this feature ticket (openedx/frontend-app-learning#1380) on the Contributions board.

@itsjeyd
Copy link

itsjeyd commented Jun 11, 2024

@ali-hugo

Updating tickets on the roadmap is out of scope for OSPR managers, ...

And vice versa: It would probably make sense to consider updating PRs on the Contributions board (changing status and/or labels) out of scope for product proposal coordinators.

That way the two groups (product working group, OSPR managers) won't be stepping on each others toes. And instead of having to become (and stay) familiar with two distinct workflows, members of each group could just focus on the workflow that's most relevant to them.

CC @mphilbrick211 @jmakowski1123

@ali-hugo
Copy link

ali-hugo commented Jun 11, 2024

@itsjeyd Thanks for the explanation. It makes sense to me to keep the two workflows separate.

I will make some suggestions on the product review procedure and ping Michelle, Jenna, and Sarina to confirm them.

@itsjeyd
Copy link

itsjeyd commented Jun 11, 2024

Awesome, thanks @ali-hugo!

I'm watching that page so you can consider me in the loop for any updates that you make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product review complete PR has gone through product review
Projects
Status: Being Developed
Development

No branches or pull requests

3 participants