Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document where to target PRs in a table in the README #3344

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

brian-smith-tcril
Copy link
Contributor

Description

Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for paragon-openedx-v22 ready!

Name Link
🔨 Latest commit e11e7cf
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx-v22/deploys/675afb6820e9ab000893d258
😎 Deploy Preview https://deploy-preview-3344--paragon-openedx-v22.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.42%. Comparing base (3a62f9e) to head (e11e7cf).
Report is 4 commits behind head on release-22.x.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-22.x    #3344   +/-   ##
=============================================
  Coverage         93.42%   93.42%           
=============================================
  Files               250      250           
  Lines              4515     4515           
  Branches           1017     1057   +40     
=============================================
  Hits               4218     4218           
+ Misses              294      291    -3     
- Partials              3        6    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -123,6 +123,14 @@ Note that if you are using ``@edx/frontend-platform``'s ``AppProvider`` componen

## Contributing

The branch to target with your PR depends on the type of change you are contributing to Paragon.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also the remove previously added section in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, removed in e11e7cf

@brian-smith-tcril brian-smith-tcril merged commit e58002f into release-22.x Dec 12, 2024
10 checks passed
@brian-smith-tcril brian-smith-tcril deleted the where-to-pr-table branch December 12, 2024 15:20
@openedx-semantic-release-bot

🎉 This PR is included in version 22.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 23.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants