chore: merge alpha into master #3158
Conversation
|
Thanks for the pull request, @PKulkoRaccoonGang! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -76,7 +76,7 @@ | |||
| "description": "Basic font weight." | |||
| }, | |||
| "lead": { "value": "inherit", "type": "fontWeight", "source": "$lead-font-weight", "description": "Lead text font weight." }, | |||
| "table-th": { "value": "normal", "type": "fontWeight", "source": "$table-th-font-weight", "description": "Table th font weight." } | |||
| "table-th": { "value": "bold", "type": "fontWeight", "source": "$table-th-font-weight", "description": "Table th font weight." } | |||
There was a problem hiding this comment.
Alpha
Master
There was a problem hiding this comment.
Thank you so much for making this PR. Landing design tokens is feeling closer than ever!
I left a couple comments about release.yml and .releaserc that we'll want to address in a separate PR before this can land.
I also noticed that commitlint is failing for this (https://github.com/openedx/paragon/actions/runs/10178424453/job/28152012015?pr=3158). I'd like to land this with the commit history intact, so rebasing to reword those commits would be helpful.
Thanks again!
| @@ -1,9 +1,12 @@ | |||
| name: Release CI | |||
|
|
|||
| on: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
Just curious as to if we want to permanently add manual workflow runs as an option or if this was a temporary thing.
| - alpha | ||
| - beta |
There was a problem hiding this comment.
Before this PR lands this file should show no changes. This will mean making a PR to current master updating this file to deploy from master and 22.x.
| "branches": [ | ||
| "master", | ||
| "next", | ||
| { "name": "alpha", "prerelease": true }, | ||
| { "name": "beta", "prerelease": true } | ||
| ], |
There was a problem hiding this comment.
Before this PR lands this file should show no changes. This will mean making a PR to current master updating this file to deploy from master and 22.x.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3158 +/- ##
==========================================
+ Coverage 93.25% 93.76% +0.51%
==========================================
Files 249 229 -20
Lines 4388 3787 -601
Branches 1035 906 -129
==========================================
- Hits 4092 3551 -541
+ Misses 293 232 -61
- Partials 3 4 +1 ☔ View full report in Codecov by Sentry. |
BREAKING CHANGE: Introduces design tokens.
* feat: resolve some Bootstrap conflicts with design tokens Co-authored-by: Peter Kulko <[email protected]>
BREAKING CHANGE: all of the deprecated components were removed from Paragon, these include `CheckBoxGroup`, `Checkbox`, `Fieldset`, `Input`, `InputSelect`, `InputText`, `ListBox`, `Modal`, `RadioButtonGroup`, `StatusAlert`, `Table`, `TextArea`, `ValidationFormGroup`, `Button.Deprecated`, `Tabs.Deprecated`, `Dropdown.Deprecated`.
* refactor: update design tokens naming and add missing ones * feat: expose replace vars script to CLI Co-authored-by: Viktor Rusakov <[email protected]>
Bumps [ws](https://github.com/websockets/ws) from 7.5.9 to 7.5.10. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.5.9...7.5.10) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…, <IconButton> (#3100) * feat: add typings for <Overlay> and <OverlayTrigger> * feat: add typings for <Tooltip> * feat: add typings for <IconButton> * chore: typing cleanups for <Chip> code * feat: slightly more detailed types for <Chip/ChipIcon> - per review
PKulkoRaccoonGang
force-pushed
the
Peter_Kulko/merge-alpha-into-master
branch
from
d6bf6a8 to
d5bb848
Compare
|
@brian-smith-tcril thanks! I fixed the commit messages. In addition to your comments, we also have several non-critical issues related to the documentation site:
We may have more issues created for the alpha version of Paragon. |
|
It sounds like this is currently an issue on This is docsite specific and we are still figuring out how we want to handle loading brand packages into the docsite going forward, so this is not a blocker. I have commented on this issue noting that we should remove This is docsite specific and not a blocker. |
According to the discussions on PWG we decided to have several branches, so this PR for inclusion in Closed |
Description
--pgn-typography-font-weight-table-thvariableMerge Checklist
exampleapp?Post-merge Checklist