[fix] Sync alpha with master #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: added bootstrap icons * refactor: some refactoring * fix: make all icons have 24x24 dimensions * fix: update icons scripts after packages update --------- Co-authored-by: Viktor Rusakov <[email protected]>
* docs: add copy URL and reset buttons to playground page * chore: use Stack component and add a variable for empty state
…espective Form sets (#1988) * feat: add ability to use unlabeled Radio and Checkbox components in respective Form sets * docs: add unlabeled control for `RadioControl` component
…eferred max width can determine when compact view occurs (#2338) * feat: add max width customizability to the stepper header's compact view --------- Co-authored-by: Jason Wesson <[email protected]>
* docs: fixed issue feedback error * refactor: after review
Co-authored-by: adamstankiewicz <[email protected]>
* fix: removed white background on Stepper.Header component * refactor: after review
react-loading-skeleton defines an exports field in its package.json which looks like this:
"exports": {
".": {
"types": "./dist/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./dist/skeleton.css": "./dist/skeleton.css"
},
The webpack documentation states that if an exports field is defined in package.json, it replaces the default module loading behavior and any other request for a module will result in a ModuleNotFound error.
Our call to load react-loading-skeleton in Paragon looks like this:
@import "~react-loading-skeleton/dist/skeleton";
That isn’t in the list of possible exports. This is though:
@import "~react-loading-skeleton/dist/skeleton.css";
This commit updates our import to the latter, which fixes downstream issues in MFEs that can’t figure out how to import react-loading-skeleton
* feat: extended edx typescript config * refactor: config refactoring * refactor: code refactoring * build: override commitlint action to fix upstream issue with typescript --------- Co-authored-by: Viktor Rusakov <[email protected]>
* feat: Add fixed increment scroll behavior to useOverflowScroll * feat: eslint, tests, docs --------- Co-authored-by: monteri <lansevermore>
* refactor: refactoring usage insights * refactor: refactorimg Usage Insights in www * refactor: refactoring structure * refactor: refactoring gatsby node * refactor: added paragon type of usage
Co-authored-by: adamstankiewicz <[email protected]>
Co-authored-by: adamstankiewicz <[email protected]>
Exposes a `paragon` CLI with an `install-theme` command.
Example usage in `package.json`:
```
{
"scripts": {
"start:with-theme": "paragon install-theme && npm start",
"build:with-theme": "paragon install-theme && npm run build"
}
}
```
The Paragon CLI will prompt from which NPM package you wish to install as the `@edx/brand` package (e.g., `@edx/brand-edx.org@latest`), and install it without modifying the `package.json` or `package-lock.json` files.
Additional commands will be added to the `paragon` CLI tool in the future.
Co-authored-by: adamstankiewicz <[email protected]>
# Conflicts: # package-lock.json # package.json # src/Card/_variables.scss # src/CheckBox/README.md # src/ColorPicker/index.scss # src/Fieldset/index.scss # src/IconButton/__snapshots__/IconButton.test.jsx.snap # src/Nav/_mixins.scss # src/Nav/_variables.scss # src/Nav/index.scss # src/OverflowScroll/index.scss # src/Popover/Popover.scss # src/SearchField/__snapshots__/SearchField.test.jsx.snap # src/Stepper/index.scss # src/Table/index.scss # src/Tabs/_variables.scss # src/Tabs/index.scss # src/index.scss # www/gatsby-node.js # www/src/components/LeaveFeedback.scss # www/src/components/Menu.tsx # www/src/pages/foundations/colors.tsx # www/src/pages/foundations/elevation.tsx # www/src/pages/foundations/spacing.tsx # www/src/pages/foundations/typography.tsx # www/src/templates/component-page-template.tsx
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2587 +/- ##
==========================================
+ Coverage 91.58% 91.95% +0.36%
==========================================
Files 214 216 +2
Lines 3519 3618 +99
Branches 852 891 +39
==========================================
+ Hits 3223 3327 +104
+ Misses 288 286 -2
+ Partials 8 5 -3 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 22.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 23.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
Aug 1, 2024
[fix] Sync alpha with master
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
Aug 4, 2024
[fix] Sync alpha with master
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
Aug 4, 2024
[fix] Sync alpha with master
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
Aug 5, 2024
[fix] Sync alpha with master
|
🎉 This PR is included in version 23.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opens #2568 as it was incorrectly squash and merged, and thus not correctly taking into account the synced commits from
masterinto thealphabranch. Needs to be merged as a normal merge commit to keep commit history.