Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch data-testid to kebab case for consistency #2620

Merged

Conversation

cintnguyen
Copy link
Contributor

Description

  • switch data-testid to kebab case for consistency
  • moved import to setuptest.js

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2d50d82
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/65036529dac44a00086baf40
😎 Deploy Preview https://deploy-preview-2620--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cintnguyen
Copy link
Contributor Author

@PKulkoRaccoonGang This should address all your comments from my previous PR, let me know if you need anything else. Thank you!

Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cintnguyen I see tests are not working, please take a look at the CI check

@brian-smith-tcril
Copy link
Contributor

I'm assuming the CI issues are due to having both RTL and enzyme included in setupTest.js.

I'm thinking this isn't an issue on the big enzyme -> RTL PR because enzyme has been fully removed from setupTest.js there.

I think the best path forward is to revert the import '@testing-library/jest-dom'; move from this PR and remove it from FormAutosuggest.test.jsxin the bigger enzyme -> RTL PR.

@cintnguyen cintnguyen force-pushed the formAutosuggest-rtl-kebabcase branch from 70280e7 to 2d50d82 Compare September 14, 2023 19:55
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (23b83c5) 91.81% compared to head (2d50d82) 91.81%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2620   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         235      235           
  Lines        4217     4217           
  Branches     1020     1020           
=======================================
  Hits         3872     3872           
  Misses        341      341           
  Partials        4        4           
Files Changed Coverage Δ
src/Form/FormAutosuggest.jsx 93.54% <ø> (ø)
src/Form/FormAutosuggestOption.jsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@viktorrusakov viktorrusakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making these updates 🙂

@viktorrusakov viktorrusakov merged commit eb0ec0d into openedx:master Sep 20, 2023
9 checks passed
@cintnguyen
Copy link
Contributor Author

LGTM! Thanks for making these updates 🙂

No problem - Thanks Viktor!

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 22.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants