-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch data-testid to kebab case for consistency #2620
chore: switch data-testid to kebab case for consistency #2620
Conversation
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@PKulkoRaccoonGang This should address all your comments from my previous PR, let me know if you need anything else. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cintnguyen I see tests are not working, please take a look at the CI check
I'm assuming the CI issues are due to having both RTL and enzyme included in I'm thinking this isn't an issue on the big enzyme -> RTL PR because enzyme has been fully removed from I think the best path forward is to revert the |
70280e7
to
2d50d82
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2620 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 235 235
Lines 4217 4217
Branches 1020 1020
=======================================
Hits 3872 3872
Misses 341 341
Partials 4 4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making these updates 🙂
No problem - Thanks Viktor! |
🎉 This PR is included in version 22.0.0-alpha.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 21.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Post-merge Checklist