Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alpha] Incorrect size of Layout component in brand-edx.org theme #2520

Open
PKulkoRaccoonGang opened this issue Aug 10, 2023 · 2 comments
Open

[alpha] Incorrect size of Layout component in brand-edx.org theme #2520

PKulkoRaccoonGang opened this issue Aug 10, 2023 · 2 comments
Assignees
@monteri
Labels
design tokens raccoon-gang

Comments

@PKulkoRaccoonGang
Copy link
Contributor

PKulkoRaccoonGang commented Aug 10, 2023 •
edited
Loading

After increasing the numeric value of the --pgn-spacing-grid-gutter-width token, the Layout component is displayed incorrectly. This problem relates to the brand-edx.org theme.

Incorrect:
image

Correct:
image
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [alpha] Incorrect size of Layout component [alpha] Incorrect size of Layout component in brand-edx.org theme Aug 10, 2023
@monteri monteri self-assigned this Dec 7, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this issue Dec 11, 2023
Open
@PKulkoRaccoonGang
Copy link
Contributor Author

PR: edx/brand-edx.org#80

@PKulkoRaccoonGang
Copy link
Contributor Author

PKulkoRaccoonGang commented Dec 11, 2023 •
edited
Loading

@adamstankiewicz Do you remember the purpose of changing the value of the gutter-width design token in this PR?

We have in the master branch of the brand-edx.org repository the value 32px for the $grid-gutter-width variable.
It seems to me that these values should match since we are just transferring existing variables to the design tokens format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monteri monteri

Labels
design tokens raccoon-gang
Projects
Paragon Working Group
Status: In review
Milestone
No milestone
Development

No branches or pull requests
2 participants
@monteri @PKulkoRaccoonGang