-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] sync alpha branch with master #2337
Conversation
* fix: refactoring Tabs component * refactor: refactoring after review * feat: added styles for tab pills * refactor: style refactoring * refactor: transfer Tabs from react-bootstrap * refactor: tabs refactoring * refactor: deleted BaseTabs * refactor: code refactoring * refactor: added tests * refactor: refactoring after review * refactor: refactoring styles and code
* feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: edit nvmrc file
* feat: added variants for the Select Menu component * refactor: refactoring after review * refactor: fixed deprecated props * refactor: refacoring component code * refactor: returned previous implementation * refactor: updated tests * refactor: code refactoring * chore: return flipping mechanic to SelectMenu --------- Co-authored-by: Viktor Rusakov <[email protected]>
* docs: added Leave Feedback link * refactor: added template message * refactor: refactoring after review
* fix: fixed double tab and styles clickable card component * refactor: code refactoring * refactor: refactoring after rebase * refactor: refactoring after review
Co-authored-by: adamstankiewicz <[email protected]>
This is released as a fix and not a breaking change because as of the moment of this commit no one is using these icons.
* docs: added missing props on the documentation site * refactor: refactoring after review * refactor: refactoring after review * chore: update props for Button and Card * chore: fix lint --------- Co-authored-by: Viktor Rusakov <[email protected]>
[SEO-478] feat: allows users to set loading type to images on CardImageCap comp…
Co-authored-by: adamstankiewicz <[email protected]>
fix: link typo for bootstrap Stack
* refactor: updated gatsby & vulnerable packages * refactor: resolved vulnerabilities for www * refactor: updated frontend-build for example app & resolved respective eslint issues * refactor: updated svgr package with breaking changes & babel/cli * refactor: updated package-lock * refactor: resolved eslint issue
# Conflicts: # package-lock.json # package.json # src/Button/deprecated/index.jsx # src/Button/index.jsx # src/Card/Card.scss # src/Nav/Nav.scss # src/Nav/_variables.scss # src/StatusAlert/index.jsx # src/Tabs/_variables.scss # src/Tabs/index.jsx # src/ValidationFormGroup/index.jsx
Thanks for the pull request, @viktorrusakov! When this pull request is ready, tag your edX technical lead. |
481177b
to
02b576e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2337 +/- ##
==========================================
+ Coverage 91.02% 91.58% +0.55%
==========================================
Files 214 214
Lines 3534 3519 -15
Branches 860 852 -8
==========================================
+ Hits 3217 3223 +6
+ Misses 309 288 -21
Partials 8 8 ☔ View full report in Codecov by Sentry. |
@viktorrusakov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 21.0.0-alpha.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 22.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sync: alpha with master
sync: alpha with master
sync: alpha with master
sync: alpha with master
🎉 This PR is included in version 23.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist