fix: primary course in landscape #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1rill
force-pushed
the
2U/fix/primary_landscape
branch
from
049426b
to
64c4468
Compare
|
Reviewing... 🚀 |
HamzaIsrar12
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Discussed it with Moiz,
The design needs improvement. According to the Figma file, the card size should remain consistent regardless of the number of buttons. If this can be fixed within a time-boxed effort, that would be great; otherwise, we can address it post-MVP.
dashboard/src/main/java/org/openedx/courses/presentation/DashboardGalleryView.kt
Outdated
Show resolved
Hide resolved
|
FYI - I think Figma is updated to reflect this proposal / design update via Eugene. Thanks for pushing this forward! |
* chore: add value prop screen event * fix: remove value_prop_enabled check for IAP * fix: put restore button behind the iap enable config * fix: Make IAP error dialog Non-Cancellable * fix: Improve IAP full screen dialog UI * fix: hide upgrade button for collapsed toolbar in course dashboard
k1rill
force-pushed
the
2U/fix/primary_landscape
branch
from
64c4468
to
cfd5099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to openedx#354
