Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFEs aren't changing html lang attribute #745

Open
igobranco opened this issue Nov 27, 2024 · 0 comments
Open

MFEs aren't changing html lang attribute #745

igobranco opened this issue Nov 27, 2024 · 0 comments

Comments

@igobranco
Copy link

When loading MFE using a language different than en-us. Eg: change the preferred language on the account MFE.

When we reload any MFE page, the lang html attribute didn't change even the application is translated to that new different language.

I think the MFEs should change the html lang attribute when it has been loaded with different language.

<html lang="en-us" dir="ltr">

Suggested change:

I think that the i18n configure function should change that value.

frontend-platform/src/i18n/lib.js

Line 262 in 07ee86c

export function configure(options) {

Create a similar Should have a handleHTMLLang similar to handleRtl function, with code:

globalThis.document.getElementsByTagName('html')[0].setAttribute('lang', getLocale());
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@igobranco