-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove core-js and regenerator-runtime #702
Conversation
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
83614f1
to
5b776ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
=======================================
Coverage 83.41% 83.41%
=======================================
Files 40 40
Lines 1073 1073
Branches 197 197
=======================================
Hits 895 895
Misses 166 166
Partials 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think it's probably worth doing an org-wide sweep to clean up these deps in other repos, regenerator-runtime
seems to be referenced all over the place
@arbrandes - I'd love to hear your thoughts on this (is there a non-obvious reason we'd need to keep these deps around?) |
5b776ec
to
72b2b3c
Compare
@brian-smith-tcril @arbrandes I'm planning to hit merge on this PR tomorrow - let me know if you have any objections. |
This makes sense to me. 👍 |
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
core-js
andregenerator-runtime
are marked as a development dependencies (for the test suites), but the tests actually pass fine without them. I think they should just be removed.Context: they are compatibility layers for older browsers/runtimes, and aren't needed in 2024.