Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example MFE application does not load styles from index.scss #441

Open
adamstankiewicz opened this issue Feb 16, 2023 · 0 comments
Open
Assignees
Labels
awaiting prioritization bug Report of or fix for something that isn't working as intended

Comments

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Feb 16, 2023

Description

The example app within this repo is defined in the example folder. It acts as an example micro-frontend (MFE). The entry point for the example app (i.e., example/index.jsx) imports a index.scss file. This SCSS file currently imports SCSS from @edx/paragon and @edx/brand.

However, when running the example app on master (i.e., npm start runs app on localhost:8080), no styles are applied to the MFE in the browser:

image

Even adding the following to example/index.scss produces no results, even though it does seem to trigger a hot reload of the application:

body { background-color: red !important; }

Other MFEs (e.g., frontend-app-profile) injects inline <style> tags into the HTML <head> for the styles defined in the MFE:

image

Whereas the example MFE in this repo does not. It only includes the JS bundle and no inline <style> tags.

image

Impacts

The impact of this issue is that it's not possible to run the example app properly to QA styles when testing a new approach for loading external theme CSS.

@adamstankiewicz adamstankiewicz added the bug Report of or fix for something that isn't working as intended label Feb 16, 2023
@adamstankiewicz adamstankiewicz moved this to Todo in FED-BOM Feb 16, 2023
@abdullahwaheed abdullahwaheed moved this from Todo to In Progress in FED-BOM Feb 28, 2023
@abdullahwaheed abdullahwaheed moved this from In Progress to Blocked in FED-BOM Mar 24, 2023
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi moved this from Blocked to Owner Review in FED-BOM Apr 11, 2023
@abdullahwaheed abdullahwaheed moved this from Owner Review to Author Team Review in FED-BOM Apr 13, 2023
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi moved this from Author Team Review to In Progress in FED-BOM Aug 7, 2023
@abdullahwaheed abdullahwaheed moved this from In Progress to Todo in FED-BOM Aug 16, 2023
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi moved this from Todo to Owner Review in FED-BOM Oct 19, 2023
@abdullahwaheed abdullahwaheed moved this from Owner Review to Todo in FED-BOM Nov 8, 2023
@abdullahwaheed abdullahwaheed moved this from Todo to Owner Review in FED-BOM Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting prioritization bug Report of or fix for something that isn't working as intended
Projects
Status: Backlog
Development

No branches or pull requests

3 participants