Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump eslint #609

Merged
merged 1 commit into from
Nov 8, 2024
Merged

chore: bump eslint #609

merged 1 commit into from
Nov 8, 2024

Conversation

arbrandes
Copy link
Contributor

@arbrandes arbrandes commented Nov 8, 2024

Bump eslint so that we get the new rules that were merged in openedx/eslint-config#164.

Bump eslint so that we get the new rules that were merged in
openedx/eslint-config#164.
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you know why renovate didn't open this PR automatically? Maybe because it was "4.2.0" instead of "^4.2.0" ?

@arbrandes
Copy link
Contributor Author

@bradenmacdonald, yeah, we were missing the caret. I don't know for sure, but I figure Renovate would respect that.

Anyway, it's conspicuously missing from most other deps as well. I didn't do any prospecting to find out why that is, but I figure at least our internal deps should have it.

@arbrandes arbrandes merged commit fe27ca5 into openedx:master Nov 8, 2024
4 checks passed
@davidjoy
Copy link
Contributor

davidjoy commented Nov 8, 2024

Last I knew, Renovate intentionally removes the ^ in an initial PR so that it can fully manage the versions. So... by design, at least as originally implemented in our repos.

@openedx-semantic-release-bot

🎉 This PR is included in version 14.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 15.0.0-alpha.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants