Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content libraries permission [FC-0062] #1545

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Dec 4, 2024

Description

This PR fixes the + Add Library button display according to the new permissions.

Addition information

Testing instructions

  • Open the course authoring mfe with a Global Staff
  • Check if the + Add Library button at the Courses and Libraries [beta] tabs show the new library form in the mfe (v2 libraries)
  • Check if the + Add Library button at the Legacy Libraries tab opens a new tab redirecting to the library page on Legacy Studio
  • Open the course authoring mfe with a user without permissions
  • Check if the + Add Library button at the Courses and Libraries [beta] tabs is not show
  • Check if the + Add Library button at the Legacy Libraries tab opens a new tab redirecting to the library page on Legacy Studio

Private ref: FAL-3987

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 4, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 4, 2024

Thanks for the pull request, @rpenido!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@rpenido rpenido changed the title fix: content libraries permission fix: content libraries permission [FC-0062] Dec 4, 2024
@rpenido rpenido added the FC Relates to an Axim Funded Contribution project label Dec 4, 2024
@rpenido rpenido force-pushed the rpenido/fal-3987-content-libraries-permission branch from 0f53602 to 92bff0c Compare December 4, 2024 15:18
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.93%. Comparing base (e75ce15) to head (7b6e89a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/studio-home/StudioHome.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1545   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files        1073     1073           
  Lines       21091    21091           
  Branches     4559     4474   -85     
=======================================
  Hits        19601    19601           
- Misses       1418     1424    +6     
+ Partials       72       66    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpenido rpenido force-pushed the rpenido/fal-3987-content-libraries-permission branch from 92bff0c to 7b6e89a Compare December 4, 2024 16:34
@rpenido
Copy link
Contributor Author

rpenido commented Dec 5, 2024

This is ready for review @bradenmacdonald!

@rpenido rpenido marked this pull request as ready for review December 5, 2024 12:25
@rpenido rpenido requested a review from a team as a code owner December 5, 2024 12:25
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Can you please open a Sumac backport PR?

@bradenmacdonald bradenmacdonald merged commit 2f1263a into openedx:master Dec 6, 2024
6 of 7 checks passed
@bradenmacdonald bradenmacdonald deleted the rpenido/fal-3987-content-libraries-permission branch December 6, 2024 18:40
@rpenido
Copy link
Contributor Author

rpenido commented Dec 6, 2024

Looks good, thanks! Can you please open a Sumac backport PR?

@bradenmacdonald Here: #1549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants