-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: content libraries permission [FC-0062] #1545
fix: content libraries permission [FC-0062] #1545
Conversation
Thanks for the pull request, @rpenido! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
0f53602
to
92bff0c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1545 +/- ##
=======================================
Coverage 92.93% 92.93%
=======================================
Files 1073 1073
Lines 21091 21091
Branches 4559 4474 -85
=======================================
Hits 19601 19601
- Misses 1418 1424 +6
+ Partials 72 66 -6 ☔ View full report in Codecov by Sentry. |
92bff0c
to
7b6e89a
Compare
This is ready for review @bradenmacdonald! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Can you please open a Sumac backport PR?
@bradenmacdonald Here: #1549 |
Description
This PR fixes the
+ Add Library
button display according to the new permissions.Addition information
Testing instructions
+ Add Library
button at theCourses
andLibraries [beta]
tabs show the new library form in the mfe (v2 libraries)+ Add Library
button at theLegacy Libraries
tab opens a new tab redirecting to the library page on Legacy Studio+ Add Library
button at theCourses
andLibraries [beta]
tabs is not show+ Add Library
button at theLegacy Libraries
tab opens a new tab redirecting to the library page on Legacy StudioPrivate ref: FAL-3987