Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability Issue: "Edit" should be elevated out of the three-dot context menu in Libraries #1488

Open
Tracked by #1509
ormsbee opened this issue Nov 7, 2024 · 9 comments

Comments

@ormsbee
Copy link
Contributor

ormsbee commented Nov 7, 2024

While doing development, the majority of the time that I was selecting a Component, it was for the purpose of editing it. This is such a common action that the Studio course unit editing page keeps the "Edit" button out of the context menu, so that users can do this in one click:

Screenshot 2024-11-07 at 6 30 28 PM

In content libraries, there are two paths, both of which require two clicks:

  • click on component card, and then click on the "Edit component" in the sidebar
  • click on the three-dot context menu for the component card, and then click "Edit"

Screenshot 2024-11-07 at 6 40 32 PM

Acceptance criteria:

  • Edit icon/button appears on Component cards, to the left of the context menu, echoing the style currently used in the course screenshot. It should be exactly equivalent to clicking on "Edit" in the context menu today.
  • "Edit" is no longer an option in the context menu for a Component.
@ormsbee
Copy link
Contributor Author

ormsbee commented Nov 7, 2024

FYI @jmakowski1123, @bradenmacdonald

@bradenmacdonald
Copy link
Contributor

It "feels" to me like double-clicking a card should open the editor / open the collection. That would be an easy fix with no UI changes?

@ormsbee
Copy link
Contributor Author

ormsbee commented Nov 8, 2024

I personally dislike the double-click metaphor for web stuff because it's not really a standard interaction, and it's not at all discoverable.

@ormsbee
Copy link
Contributor Author

ormsbee commented Nov 8, 2024

But then again, I'm a web luddite who used Google Apps for years and years before realizing you could double-click there, so I'll defer to Product and UX. 😛

@jmakowski1123
Copy link

Pulling in @lizc577

@rpenido
Copy link
Contributor

rpenido commented Feb 18, 2025

Hi team! @jmakowski1123 @lizc577 @bradenmacdonald @ormsbee

Can we move forward with the proposal of promoting the "Edit" item to the title header?

Note that we use the same menu on the sidebar, where we already have an Edit option outside the menu.
Image

@jmakowski1123
Copy link

It makes sense to me from a page hierarchy standpoint. Do we now need the edit in both the header space and the 3-dot dropdown? Seems like unnecessary redundancy? @sdaitzman

Image

@sdaitzman
Copy link

I think we should support double-click as a shortcut rather than adding an edit item to each object. Double-click to open/edit/play is a common interaction pattern, and the component cards deliberately echo the object design used by lots of common platforms with selectable objects that can be quickly opened. I don't think adding an open/edit option to each item is worth the added space/repeating icon on every object.

(This is an aside, but I do think we should improve double-click handling to make it a better shortcut option. Currently, double-clicks to open collections are actually single-clicks on selected collections. This results in some weird unexpected behavior.)

@rpenido
Copy link
Contributor

rpenido commented Feb 25, 2025

Do we now need the edit in both the header space and the 3-dot dropdown? Seems like unnecessary redundancy?

Sure! We have it because (for consistency) we reuse the same menu for the 3-dot menu and the Sidebar. I was just commenting that removing the "Edit" menu item will also fix this redundancy.

So, should we proceed with the double-click approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

5 participants