Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching within the active/archived courses list returns results from the entire course list #1477

Open
mariajgrimaldi opened this issue Nov 6, 2024 · 6 comments
Labels
bug Report of or fix for something that isn't working as intended release testing Affects the upcoming release (attention needed)

Comments

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Nov 6, 2024

Description

The archived/active filter on the Studio Home is not working as expected when using them with searching. When users attempt to filter for active/archived courses by using the 'Archived' option in combination with search actions, active courses are displayed instead of only archived ones.

Steps to Reproduce

  1. Go to the Studio home page.
  2. Select the archived option and enter the name of an active course in the search bar field.

Expected Result:
The system should display only archived courses based on the filters and search term. If no results are found, it should display the message: "We could not find any results."

Actual Result:
The system displays active courses in the list instead of archived ones.

This behavior repeats with active courses.

Additional Information

I'm guessing this issue was happening since this feature was introduced. When selecting active/archived, and then searching, the archived_only or active_only filters are somehow removed, resulting in filtering all courses instead.

Originally posted here: openedx/wg-build-test-release#403

@mariajgrimaldi mariajgrimaldi added the release testing Affects the upcoming release (attention needed) label Nov 6, 2024
@mariajgrimaldi
Copy link
Member Author

I was part of this implementation, so I'll spend some time researching the issue or have someone on my team take a look. Additionally, I'm aware of the technical debt related to deprecating search API V1 in favor of V2, which I also have on my radar.

FYI @bradenmacdonald

@mariajgrimaldi mariajgrimaldi added the bug Report of or fix for something that isn't working as intended label Nov 7, 2024
@bra-i-am
Copy link
Contributor

bra-i-am commented Nov 12, 2024

hi @mariajgrimaldi, sorry for the delay

This #1497 little PR contains the fix to solve this issue

I left the previously opened PR that you told me to use as a backport #1496

Please let me know any comments you have :D

@crathbun428
Copy link

Hi @mariajgrimaldi - I believe this may be the same as this high-priority bug on the test failures board, no?

@mariajgrimaldi
Copy link
Member Author

@crathbun428: yes! I linked the issue in the description in the originally posted section. Thank you!

@mariajgrimaldi
Copy link
Member Author

FYI @farhaanbukhsh

@farhaanbukhsh
Copy link
Member

@mariajgrimaldi Reviewed, should I merge these as well or you want a CC to do that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended release testing Affects the upcoming release (attention needed)
Projects
Status: Backlog
Development

No branches or pull requests

4 participants