Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow for library-sourced content (Authoring MFE - Unit Page) #1464

Open
bradenmacdonald opened this issue Nov 4, 2024 · 9 comments
Assignees

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Nov 4, 2024

  1. When a component in a course is sourced from a v2 library and a newer version is available in the library, display the "Update Available" button. This is already implemented on the legacy Unit page; this task is porting it to the new MFE unit page.

Screenshot

  1. When the button is clicked, display a modal with the <CompareChangesWidget>:

Screenshot

  1. The modal should be large to facilitate previewing the components.
  2. The previews should be interactive (this is already implemented)
  3. The "Accept Changes" and "Ignore Changes" buttons should both work, as they already work in the legacy UI.
  4. Use a Paragon modal for this. It will look different from the legacy UI screenshot seen above.
@bradenmacdonald
Copy link
Contributor Author

@jmakowski1123 FYI

@jmakowski1123
Copy link

cc @GlugovGrGlib for visibility. These are small additions being made to the new unit page MFE.

@navinkarkera
Copy link
Contributor

@bradenmacdonald Now that the course unit is an iframe that displays the legacy UI, is this issue relevant?

@bradenmacdonald
Copy link
Contributor Author

@navinkarkera Yes, we should be intercepting the events from the iframe and displaying this modal from the Authoring MFE, not from the legacy page. See how they're doing it for the "Move XBlock" modal: #1422

@navinkarkera
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@navinkarkera navinkarkera moved this from Backlog to Ready for AC testing in Libraries Overhaul Nov 23, 2024
@sdaitzman
Copy link

Looks good to me!

image

Similarly to some other areas, the number of concentric boxes is a bit high here, but I don't think it's a blocker for this.

image

@navinkarkera
Copy link
Contributor

navinkarkera commented Nov 26, 2024

@sdaitzman This issue is about displaying the preview changes modal from the new course unit page. You can test it here.

The sandbox is set to take you legacy course unit page by default, but we flip this temporarily if required.

@sdaitzman
Copy link

Thanks @navinkarkera! Tested a few rounds of updates and the ignore changes feature.

Just out of curiosity, what determines whether the legacy/updated course unit page will be shown?

image

@bradenmacdonald
Copy link
Contributor Author

@sdaitzman It's a setting that the administrator controls. There is currently no way for users to toggle the setting nor choose for themselves (though that's something I've been pushing for).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for AC testing
Development

No branches or pull requests

4 participants