Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide / error on Libraries v2 pages if !librariesV2Enabled #1448

Open
pomegranited opened this issue Oct 30, 2024 · 2 comments
Open

Hide / error on Libraries v2 pages if !librariesV2Enabled #1448

pomegranited opened this issue Oct 30, 2024 · 2 comments
Assignees
@pomegranited
Labels
bug Report of or fix for something that isn't working as intended

Comments

@pomegranited
Copy link
Contributor

Accessing the Library Home page (e.g. https://app.tagging-preview.staging.do.opencraft.hosting/course-authoring/library/lib:OpenCraft:TL) should give an error if the "disable v2 libraries" waffle flag is set.

It's totally fine if this error happens after the initial page load - since having v2 libraries enabled is the default we don't want to block loading until the waffle flag is checked.
@pomegranited pomegranited moved this to Backlog in Libraries Overhaul Oct 30, 2024
@pomegranited pomegranited added the bug Report of or fix for something that isn't working as intended label Oct 30, 2024
@pomegranited pomegranited mentioned this issue Oct 30, 2024
Merged
@bradenmacdonald bradenmacdonald moved this from Backlog to In Progress in Libraries Overhaul Oct 30, 2024
@pomegranited pomegranited moved this from In Progress to Ready for AC testing in Libraries Overhaul Nov 7, 2024
@pomegranited
Copy link
Contributor Author

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@ChrisChV
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts Friendly reminder that this is ready for AC testing on the sandbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomegranited pomegranited

Labels
bug Report of or fix for something that isn't working as intended
Projects
Libraries Overhaul
Status: Ready for AC testing
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pomegranited @ChrisChV