-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow filtering library by publish status [FC-0062] #1406
base: master
Are you sure you want to change the base?
Allow filtering library by publish status [FC-0062] #1406
Conversation
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
a68529c
to
cac19a1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1406 +/- ##
==========================================
- Coverage 92.94% 92.93% -0.01%
==========================================
Files 1073 1076 +3
Lines 21098 21227 +129
Branches 4550 4491 -59
==========================================
+ Hits 19610 19728 +118
- Misses 1422 1433 +11
Partials 66 66 ☔ View full report in Codecov by Sentry. |
Description
Adds a filter widget:
And an "Unpublished changes" badge:
TODO
Get the filter working properly - add a filterable "publish_status" field on the backend Meilisearch index which is set to "published", "modified", or "never". It seems that this is necessary because Meilisearch can filter on things like
modified > 23849345
but NOT on things likemodified > last_published
Fix i18n
Write tests