Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Manage Users/Permissions" for v2 Libraries #1342

Open
2 tasks
bradenmacdonald opened this issue Sep 26, 2024 · 7 comments
Open
2 tasks

"Manage Users/Permissions" for v2 Libraries #1342

bradenmacdonald opened this issue Sep 26, 2024 · 7 comments

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Sep 26, 2024

Need product/UX requirements here.

Describe how to access this panel - in a tab of the library info sidebar?

Backend notes

Here is what is already implemented on the backend:

There are no org-level permissions.

Users can be added to the team of each library, in one of three roles:

  • read-only: can view the content, can use it in courses. Cannot see who else is on the team. Cannot edit anything.
  • author: can view and edit the content (create/edit/delete components + collections), can use content in courses. Can see who is on the team and what permissions they have. Cannot edit the team nor delete the library.
  • admin: same as author plus can edit who is on the team and can delete the whole library.

Global staff are like admins on all libraries.

There are also two settings that each library has (only admins can change):

  • "Allow public read" - if this checkbox is selected for the library, anyone with Studio access can view the content and use it in courses; they don't have to be explicitly added to the library team.
  • "Allow public learning" - this is an advanced feature that allows authors to get a special URL and can then embed the content almost anywhere, allowing learners to access a component directly from the library (storing their answers, grade, etc.) - no course involved. Recommend keeping this option hidden for MVP. It was only used by LabXchange.
@bradenmacdonald
Copy link
Contributor Author

@jmakowski1123 Please add the product/UX requirements here :)

@pomegranited
Copy link
Contributor

@jmakowski1123 CC @bradenmacdonald

FYI until the full design is ready, I'm starting with a modal based on the existing Course Team UI:

image

@pomegranited
Copy link
Contributor

Hi @jmakowski1123 @lizc577 @sdaitzman @marcotuts I've deployed my Draft #1362 to the tagging-preview sandbox.

Could someone take a look and let me if anything needs changing for MVP? I could use your input on the UX and text I chose.

To access the new Library Team modal:

  1. Select a library from the list of v2 Libraries, and open the Library Info sidebar.
  2. If you have Admin access to that library (or are Global Staff), you should see a "Manage Access" button, where you can add/remove team members and change their access levels.
  3. If you only have Author access to the library, you can only view the Library Team, not make changes.
  4. If you only have Read access to a library, you cannot view the Library Team (and won't see a "Manage Access" button at all).

@ChrisChV
Copy link
Contributor

Hi @jmakowski1123 @lizc577 @sdaitzman @marcotuts friendly reminder that this is ready for AC testing on the sandbox

@sdaitzman
Copy link

Looks good to me overall! I think it would make sense to examine the right-side button interface in a future update, and consider switching to a dropdown. I think this is a reasonable approach to take for now.

I did notice that when using the button to add a new team member, the error that appears when adding a non-registered user ("Error adding team member") is nonspecific. Would it be possible to add a description like "Check that the email is entered correctly, and corresponds to a registered user" or similar? Or, could we add a specific "User not found" error (is there any security issue in this logged-in admin context)?

image

@ChrisChV
Copy link
Contributor

ChrisChV commented Dec 6, 2024

I did notice that when using the button to add a new team member, the error that appears when adding a non-registered user ("Error adding team member") is nonspecific.

Fixed! @jmakowski1123 @sdaitzman It's ready for AC testing on the sandbox

@sdaitzman
Copy link

Thanks @ChrisChV, looks good to me!

I did notice that the new error appears when trying to add a user who has already been added to the library, could we add a distinct error message for that case? Something like: "Error adding team member. That user is already on this team."

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for AC testing
Development

No branches or pull requests

4 participants