feat: sync full metadata for restricted courses #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
force-pushed
the
aed/sync-full-restricted-courses
branch
2 times, most recently
from
73cd033
to
f92b203
Compare
iloveagent57
commented
Oct 21, 2024
Comment on lines
-347
to
-351
| program_content_keys = create_course_associated_programs( | ||
| course_metadata_dict.get('programs', []), | ||
| metadata_record, | ||
| ) | ||
| _update_full_content_metadata_program(program_content_keys, dry_run) |
There was a problem hiding this comment.
Only change here was yanking this out of _update_single_full_course_record() and into the calling function, to better isolate responsibilities and avoid duplicate work.
iloveagent57
force-pushed
the
aed/sync-full-restricted-courses
branch
8 times, most recently
from
d821a22
to
e04d0f1
Compare
iloveagent57
commented
Oct 23, 2024
Comment on lines
+13
to
+24
| operations = [ | ||
| migrations.AddField( | ||
| model_name='restrictedcoursemetadata', | ||
| name='restricted_run_allowed_for_restricted_course', | ||
| field=models.ManyToManyField(through='catalog.RestrictedRunAllowedForRestrictedCourse', to='catalog.contentmetadata'), | ||
| ), | ||
| migrations.AlterField( | ||
| model_name='restrictedrunallowedforrestrictedcourse', | ||
| name='course', | ||
| field=models.ForeignKey(null=True, on_delete=django.db.models.deletion.SET_NULL, to='catalog.restrictedcoursemetadata'), | ||
| ), | ||
| ] |
There was a problem hiding this comment.
This is a SQL no-op.
iloveagent57
force-pushed
the
aed/sync-full-restricted-courses
branch
5 times, most recently
from
c21303f
to
8c0daa7
Compare
|
Made some recent updates to this branch:
|
iloveagent57
force-pushed
the
aed/sync-full-restricted-courses
branch
from
8c0daa7
to
1b33e17
Compare
adamstankiewicz
approved these changes
Oct 28, 2024
| """ | ||
| Given a fetched dictionary of course content metadata and an option `course_review` record, | ||
| updates an existing course `ContentMetadata` instance with the "full" dictionary of `json_metadata` | ||
| for that course. | ||
| """ | ||
| # Merge the full metadata from discovery's /api/v1/courses into the local metadata object. | ||
| metadata_record._json_metadata.update(course_metadata_dict) # pylint: disable=protected-access | ||
| if not skip_json_metadata_update: |
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENT-9597
Local Testing
Set up a restricted course run locally
It'll be associated with DemoX: https://2u-internal.atlassian.net/wiki/spaces/SOL/pages/1317306375/Setting+up+restricted+runs+locally
Enable the setting
In your
private.pysettings file, setSHOULD_FETCH_RESTRICTED_COURSE_RUNS = True. Optionally setSHOULD_INDEX_COURSES_WITH_RESTRICTED_RUNS = Trueif you'd like to test against a dev algolia index, too.Sync full course metadata
make worker-restart worker-logsmake app-shelland then./manage.py update_content_metadata --force(note that this mgmt command runs both theupdate_catalog_metadatatask and theupdate_full_content_metadata_task.)./manage.py reindex_algolia --force --no-asyncPost-review