Upgrading history package #678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts-5023223 Python Requirements Update
awais786
commented
Sep 26, 2023
| upgrade: export CUSTOM_COMPILE_COMMAND=make upgrade | ||
| upgrade: piptools ## update the requirements/*.txt files with the latest packages satisfying requirements/*.in | ||
| # Make sure to compile files after any other files they include! | ||
| COMMON_CONSTRAINTS_TXT=requirements/common_constraints.txt |
There was a problem hiding this comment.
it was not working as expected. Fixed.
awais786
commented
Sep 26, 2023
| name='historicalenterprisecatalog', | ||
| options={'get_latest_by': ('history_date', 'history_id'), 'ordering': ('-history_date', '-history_id'), 'verbose_name': 'historical Enterprise Catalog', 'verbose_name_plural': 'historical Enterprise Catalogs'}, | ||
| ), | ||
| migrations.AlterField( |
There was a problem hiding this comment.
This migration
model_name='catalogquery', name='content_filter', is part of some old change in this repo.
awais786
commented
Sep 26, 2023
| operations = [ | ||
| migrations.AlterModelOptions( | ||
| name='historicalcontentmetadata', | ||
| options={'get_latest_by': ('history_date', 'history_id'), 'ordering': ('-history_date', '-history_id'), 'verbose_name': 'historical Content Metadata', 'verbose_name_plural': 'historical Content Metadata'}, |
There was a problem hiding this comment.
its due to history-table.
awais786
commented
Sep 26, 2023
| operations = [ | ||
| migrations.AlterModelOptions( | ||
| name='historicalcontentmetadata', | ||
| options={'get_latest_by': ('history_date', 'history_id'), 'ordering': ('-history_date', '-history_id'), 'verbose_name': 'historical Content Metadata', 'verbose_name_plural': 'historical Content Metadata'}, |
There was a problem hiding this comment.
these are expected due to history package.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading history package to its latest version. To minimize the django42 scope make this separate PR.
https://django-simple-history.readthedocs.io/en/latest/#section-1
Upgrading the package.
jazzband/django-simple-history#862 ( this pr shows the get_latest_by usage )
Similars PR merged in credentials openedx/credentials#1787
and platform openedx/edx-platform#32880