Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add code owner tracking to celery tasks. #2070

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

dianakhuang
Copy link
Contributor

@dianakhuang dianakhuang commented Oct 10, 2023

This adds the decorator for ensuring celery tasks
get assigned the proper code owner on the LMS.

Documentation on how and why to do this: https://github.com/openedx/edx-django-utils/blob/master/edx_django_utils/monitoring/docs/how_tos/add_code_owner_custom_attribute_to_an_ida.rst#id7

Developer Checklist

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@dianakhuang dianakhuang requested a review from a team as a code owner October 10, 2023 16:26
This adds the decorator for ensuring celery tasks
get assigned the proper code owner on the LMS.
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b395329) 94.93% compared to head (f57f5f7) 94.93%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2070   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         183      183           
  Lines       18623    18628    +5     
  Branches     1704     1704           
=======================================
+ Hits        17679    17684    +5     
  Misses        712      712           
  Partials      232      232           
Flag Coverage Δ
unittests 94.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
openassessment/__init__.py 100.00% <100.00%> (ø)
openassessment/workflow/tasks.py 63.63% <100.00%> (+10.69%) ⬆️
...enassessment/workflow/workflow_batch_update_api.py 80.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dianakhuang dianakhuang merged commit ab631ae into master Oct 10, 2023
7 checks passed
@dianakhuang dianakhuang deleted the diana/set-code-owner branch October 10, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants