-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update assessments formats #2106
Merged
nsprenkle
merged 3 commits into
feat/2023-dual-ui
from
nsprenkle/bff-update-assessments-format
Nov 2, 2023
Merged
refactor: update assessments formats #2106
nsprenkle
merged 3 commits into
feat/2023-dual-ui
from
nsprenkle/bff-update-assessments-format
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frontend now uses a data format which differs from how we store assessments in the backend. Had to create a bunch of extra serializers to handle these different views and directions of data transformation. Ideally there is follow-up work here to minimize the number of one-off serializers and consolidate some of that logic.
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/2023-dual-ui #2106 +/- ##
=====================================================
+ Coverage 94.97% 94.98% +0.01%
=====================================================
Files 191 191
Lines 20383 20448 +65
Branches 1848 1851 +3
=====================================================
+ Hits 19359 19423 +64
- Misses 769 770 +1
Partials 255 255
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
leangseu-edx
approved these changes
Nov 2, 2023
nsprenkle
added a commit
that referenced
this pull request
Nov 6, 2023
* refactor: update assessments data format Frontend now uses a data format which differs from how we store assessments in the backend. Had to create a bunch of extra serializers to handle these different views and directions of data transformation. Ideally there is follow-up work here to minimize the number of one-off serializers and consolidate some of that logic.
nsprenkle
added a commit
that referenced
this pull request
Nov 6, 2023
* refactor: update assessments data format Frontend now uses a data format which differs from how we store assessments in the backend. Had to create a bunch of extra serializers to handle these different views and directions of data transformation. Ideally there is follow-up work here to minimize the number of one-off serializers and consolidate some of that logic.
nsprenkle
added a commit
that referenced
this pull request
Nov 6, 2023
* refactor: update assessments data format Frontend now uses a data format which differs from how we store assessments in the backend. Had to create a bunch of extra serializers to handle these different views and directions of data transformation. Ideally there is follow-up work here to minimize the number of one-off serializers and consolidate some of that logic.
BryanttV
pushed a commit
to eduNEXT/edx-ora2
that referenced
this pull request
Feb 6, 2024
* refactor: update assessments data format Frontend now uses a data format which differs from how we store assessments in the backend. Had to create a bunch of extra serializers to handle these different views and directions of data transformation. Ideally there is follow-up work here to minimize the number of one-off serializers and consolidate some of that logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - Update assessments data format used to communicate with frontend.
JIRA: AU-1528 and AU-1525 (closes #2103 )
What changed?
Frontend now uses this format to communicate assessments data to / from the backend:
Included supporting changes to convert this to the format used by the backend to submit an assessment.
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora