-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ORA staff grader mfe endpoints upgraded #2095
feat: ORA staff grader mfe endpoints upgraded #2095
Conversation
Thanks for the pull request, @nandodev-net! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
given by the owner of the 'submission_uuid' for other submissions in the same item. | ||
""" | ||
item_id = data['item_id'] | ||
subission_uuid = data['submission_uuid'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subission_uuid = data['submission_uuid'] | |
submission_uuid = data['submission_uuid'] |
"scorer_name": scorer_name, | ||
"scorer_username": scorer_username, | ||
"scorer_email": scorer_email, | ||
"assesment_date": assessment.scored_at.strftime('%d-%m-%Y'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the time return as well?
This work done by @nandodev-net will be continued from the next PR. From now on, I will take responsibility for any modifications that need to be made in the implementation. |
@nandodev-net Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
ORA staff grader endpoints upgrade
For this PR we have the following goals:
/api/ora_staff_grader/assessments/feedback
endpoint in order to list the assessments grades based on the type (received or given) for a specific submission./api/ora_staff_grader/initialize
endpoint in order to add thefullname
andemail
fields.Descriptions
/api/ora_staff_grader/assessments/feedback
This endpoint fetches assessment details for a given submission UUID, assessment_fillter [
given
,received
] and ORA_location, including scorer information and scoring details in order to fill the following Staff Grade MFE table:Modifications were made in the following directories:
Click here! to see `/api/ora_staff_grader/assessments/feedback` output
/api/ora_staff_grader/initialize
This is a pre-existing endpoint to which two extra fields are added [
fullname
,email
].Modifications were made in the following directories:
Click here! to see `/api/ora_staff_grader/initialize` output
Testing
In order to test this, you can use the API platform Postman:
given
,received
]This upgrade will consist of two PRs: one for ORA and the other for edx-platform. This is because the main serializer of the service resides in the platform. To test it, you'll need to fetch and set up the version of the platform with the serializer modification.