fix: no rubric validation added

[Inferato]

TL;DR -
Save ORA w/o prompt cause an error

What changed?

• Added no prompt validation
• validate_rubric placed on top of validations

Developer Checklist

• Reviewed the release process
• Translations and JS/SASS compiled
• Bumped version number in openassessment/__init__.py and package.json

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

• I've done a visual code review
• I've tested the new functionality

FYI: @openedx/content-aurora

[openedx-webhooks]

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1b6eea) 95.02% compared to head (c2feab6) 95.02%.
Report is 37 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2092   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         191      191           
  Lines       20520    20529    +9     
  Branches     1856     1857    +1     
=======================================
+ Hits        19499    19508    +9     
  Misses        766      766           
  Partials      255      255           

Flag	Coverage Δ
unittests	95.02% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[itsjeyd]

@Inferato Thank you for your contribution! Please let us know when it is ready for review.

[Inferato]

@itsjeyd Now it's ready for review.

[itsjeyd]

@Inferato OK great!

@mattcarter This is ready for engineering review by Aurora.

[itsjeyd]

@mattcarter Friendly ping about scheduling a review for this PR.

CC @openedx/2u-aurora

[itsjeyd]

@pomegranited Perhaps you could have a look at this PR, too?

[pomegranited]

Hi @Inferato , thank you for submitting this change! It works as described.

I've tested it and it works great, but have left a note about the translation changes. Once you address these issues, I'll approve and get this merged.

• I tested this on my devstack:
  • Had to enable the course_live.enable_course_live waffle flag
    (Unrelated to this change, editing ORA components in Studio threw missing template errors without this flag?)
  • Added a new ORA2 component to my test course
  • Removed all "prompts" from the component and saved.
    Noted new error: "You must provide at least one prompt."
    (ora2 master raises an IndexError in the backend, but shows the user no details.)
• I read through the code
• I checked for accessibility issues by using my keyboard only during testing
• Includes documentation N/A
• User-facing strings are extracted for translation

[pomegranited]

@Inferato I notice that most of the changes made to these translation files are just changes to the line length? I'm not sure why that happened.. maybe you have an older version of gettext?

I'm running:

$ gettext --version
gettext (GNU gettext-runtime) 0.19.8.1
Copyright (C) 1995-1997, 2000-2007 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Written by Ulrich Drepper.

Could you please check/update your gettext and regenerate the translations? And if you could resolve the conflicts at the same time, that would be great :)

[dyudyunov]

Hi @pomegranited

Sorry for the delays, Taras is no longer a member of RG.
Currently, I'm gathering all the PRs he worked on. I will check their statuses and update them if necessary.

I will leave the status update comments on each PR's comments ASAP

[pomegranited]

Hi @dyudyunov no worries, thank you for letting us know.
If you end up having to close this PR and open a new one, feel free to ping me for review.

[dyudyunov]

@pomegranited could you close this PR in favor of #2173?

[openedx-webhooks]

@Inferato Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.