-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Olive Release Notes #2093
Olive Release Notes #2093
Conversation
Thanks for the pull request, @pdpinch! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
2554751
to
022d17f
Compare
a8cb4a1
to
46221fc
Compare
61fef30
to
104d855
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great, thanks a lot @pdpinch!
I made a couple of totally optional suggestions, but there are a couple of changes I'm actually asking for. (Hopefully the distinction is clear in context.)
Learner Records Micro-frontend (MFE) | ||
------------------------------------ | ||
|
||
- The Learner records MFE is now available as an optional frontend for the Credentials application. See the `Learner Records MFE README`_ for configuration information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: maybe we should explicitly mention that Credentials needs to be installed and running for the LRMFE to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the Learner Records MFE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, would love to see some more info here so that operators would know what they'd be changing by enabling the LRMFE. I have a vague understanding that the MFE is incrementally replacing some legacy pages from Crededentials (and LMS too?), but I don't know enough to write the blurb myself.
@hurtstotouchfire would you be able to suggest a sentence or two on what the LRMFE adds to Olive?
aadb331
to
44f690c
Compare
@arbrandes @ghassanmas @regisb I added a brief section on the MFE runtime config to breaking changes. Let me know if it's too much. I also accepted Adolfo's "upgrade note" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested fixes to my earlier suggestions. Otherwise, looks great to me!
Sorry I meant en_us/open_edx_release_notes/images/palm/new_ora_grading_experience.png |
Co-authored-by: Adolfo R. Brandes <[email protected]>
Co-authored-by: Adolfo R. Brandes <[email protected]>
Co-authored-by: Adolfo R. Brandes <[email protected]>
7c30892
to
222931c
Compare
@pdpinch 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Thanks for the approval @kdmccormick -- I needed that before I could merge. |
@pdpinch I see you removed en_us/open_edx_release_notes/images/palm/new_ora_grading_experience.png - is that because the change didn't go into the release? (I'm writing blog posts and this seems interesting, if included) |
Olive Release Notes.
part of openedx/wg-build-test-release#229
Date Needed (optional)
Nutmeg will be released on Decmber 9, 2022
Reviewers
Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives 👍.
@blarghmatey @shaidar @shellyu @cachob
Testing
HTML Version (optional)
Sandbox (optional)
Post-review