Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Olive Release Notes #2093

Merged
merged 82 commits into from
Dec 19, 2022
Merged

Olive Release Notes #2093

merged 82 commits into from
Dec 19, 2022

Conversation

pdpinch
Copy link
Contributor

@pdpinch pdpinch commented Nov 20, 2022

Olive Release Notes.

part of openedx/wg-build-test-release#229

Date Needed (optional)

Nutmeg will be released on Decmber 9, 2022

Reviewers

Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives 👍.

  • Subject matter expert: @sarina
  • Subject matter expert: @feanil
  • Subject matter expert: @nedbat
  • Subject matter expert: @kdmccormick
  • Subject matter expert: @ghassanmas
  • Doc team review (sanity check, copy edit, or dev edit?): @edx/doc
  • Product review: @jmakowski1123
  • PM review: n/a (Is a PM different from Product Review?)

@blarghmatey @shaidar @shellyu @cachob

Testing

  • Ran ./run_tests.sh without warnings or errors

HTML Version (optional)

Sandbox (optional)

Post-review

  • Add a comment with the description of this change or link this PR to the next release notes task.
  • Squash commits

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 20, 2022
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 20, 2022

Thanks for the pull request, @pdpinch! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@pdpinch pdpinch force-pushed the pdpinch/olive-release-notes branch 2 times, most recently from 2554751 to 022d17f Compare November 20, 2022 18:54
@pdpinch pdpinch force-pushed the pdpinch/olive-release-notes branch 4 times, most recently from a8cb4a1 to 46221fc Compare December 5, 2022 02:15
@pdpinch pdpinch force-pushed the pdpinch/olive-release-notes branch from 61fef30 to 104d855 Compare December 11, 2022 19:49
@pdpinch pdpinch marked this pull request as ready for review December 11, 2022 20:52
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great, thanks a lot @pdpinch!

I made a couple of totally optional suggestions, but there are a couple of changes I'm actually asking for. (Hopefully the distinction is clear in context.)

en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
Learner Records Micro-frontend (MFE)
------------------------------------

- The Learner records MFE is now available as an optional frontend for the Credentials application. See the `Learner Records MFE README`_ for configuration information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: maybe we should explicitly mention that Credentials needs to be installed and running for the LRMFE to work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the Learner Records MFE?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, would love to see some more info here so that operators would know what they'd be changing by enabling the LRMFE. I have a vague understanding that the MFE is incrementally replacing some legacy pages from Crededentials (and LMS too?), but I don't know enough to write the blurb myself.

@hurtstotouchfire would you be able to suggest a sentence or two on what the LRMFE adds to Olive?

en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Show resolved Hide resolved
@pdpinch pdpinch changed the title WIP: Olive Release Notes Olive Release Notes Dec 12, 2022
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Show resolved Hide resolved
@pdpinch pdpinch force-pushed the pdpinch/olive-release-notes branch from aadb331 to 44f690c Compare December 13, 2022 02:00
@pdpinch
Copy link
Contributor Author

pdpinch commented Dec 13, 2022

@pdpinch pdpinch requested review from sarina and arbrandes December 13, 2022 03:12
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested fixes to my earlier suggestions. Otherwise, looks great to me!

en_us/open_edx_release_notes/source/olive.rst Show resolved Hide resolved
en_us/open_edx_release_notes/source/olive.rst Outdated Show resolved Hide resolved
@sarina
Copy link
Contributor

sarina commented Dec 13, 2022

@pdpinch where do you use the en_us/open_edx_release_notes/images/olive/page_and_resources_view.png file? I want to know more about that change

Sorry I meant en_us/open_edx_release_notes/images/palm/new_ora_grading_experience.png

@pdpinch pdpinch force-pushed the pdpinch/olive-release-notes branch from 7c30892 to 222931c Compare December 19, 2022 02:13
@pdpinch pdpinch merged commit 5274eeb into master Dec 19, 2022
@pdpinch pdpinch deleted the pdpinch/olive-release-notes branch December 19, 2022 02:24
@openedx-webhooks
Copy link

@pdpinch 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@pdpinch
Copy link
Contributor Author

pdpinch commented Dec 19, 2022

Thanks for the approval @kdmccormick -- I needed that before I could merge.

@sarina
Copy link
Contributor

sarina commented Dec 19, 2022

@pdpinch I see you removed en_us/open_edx_release_notes/images/palm/new_ora_grading_experience.png - is that because the change didn't go into the release? (I'm writing blog posts and this seems interesting, if included)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants