chore: fix timing issue with logging overrides #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that the call to `get_logger` happens after the configuration file overrides have a chance to set `LOGGING_FORMAT_STRING`. FIXES: APER-3805
justinhynes
reviewed
Dec 6, 2024
Comment on lines
+50
to
+52
| # make sure this happens after the configuration file overrides so format string can be overridden | ||
| LOGGING = get_logger_config(format_string=LOGGING_FORMAT_STRING) | ||
|
|
There was a problem hiding this comment.
:bonks own forhead: yeah, this makes sense 🤞
justinhynes
approved these changes
Dec 6, 2024
deborahgu
deleted the
dkaplan1/APER-3805_take-4-fix-datadog-log-parsing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that the call to
get_loggerhappens after the configuration file overrides have a chance to setLOGGING_FORMAT_STRING.FIXES: APER-3805
Run JavaScript tests locally with Karma
There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.
make test-karma