Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

fix: vulnerable to cross-app script injection via crafted intent #1833

Merged
merged 2 commits into from
Oct 23, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions OpenEdXMobile/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,10 @@

<activity
android:name=".view.dialog.WebViewActivity"
android:exported="false"
android:screenOrientation="portrait"
android:exported="true"
android:theme="@style/AppTheme.NoActionBar.TranslucentStatusBar">
android:theme="@style/AppTheme.NoActionBar.TranslucentStatusBar"
tools:ignore="AppLinkUrlError">
<intent-filter>
<category android:name="android.intent.category.DEFAULT" />
<action android:name="android.intent.action.VIEW" />
Expand All @@ -255,11 +256,11 @@
<!--Google cast expanded controls activity-->
<activity
android:name="org.edx.mobile.googlecast.ExpandedControlsActivity"
android:exported="false"
android:launchMode="singleTask"
android:theme="@style/Theme.CastVideosTheme"
android:exported="true">
android:theme="@style/Theme.CastVideosTheme">
<intent-filter>
<action android:name="android.intent.action.MAIN"/>
<action android:name="android.intent.action.MAIN" />
</intent-filter>
</activity>

Expand Down Expand Up @@ -346,7 +347,7 @@
<service
android:name="org.edx.mobile.notifications.services.NotificationService"
android:enabled="${fcmEnabled}"
android:exported="true">
android:exported="false">
<intent-filter>
<action android:name="com.google.firebase.MESSAGING_EVENT"/>
</intent-filter>
Expand Down
Loading