This repository has been archived by the owner on May 6, 2024. It is now read-only.
fix: vulnerable to cross-app script injection via crafted intent #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1833 +/- ##
===========================================
- Coverage 1.08% 1.07% -0.01%
Complexity 137 137
===========================================
Files 538 538
Lines 26293 26300 +7
Branches 3381 3384 +3
===========================================
Hits 284 284
- Misses 25982 25989 +7
Partials 27 27 ☔ View full report in Codecov by Sentry. |
- Mitigated the vulnerability by disabling the ability to open custom-defined inner URIs through external sources. This was achieved by setting `android:exported="false"`. - Setting `android:exported="false"` for the android component doesn't need to call out side from the app. fixes: LEARNER-9557
farhan-arshad-dev
force-pushed
the
farhan_ar/LEARNER-9557
branch
from
a9c9da4 to
c3da710
Compare
HamzaIsrar12
suggested changes
Oct 18, 2023
fixes: LEARNER-9557
HamzaIsrar12
approved these changes
Oct 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEARNER-9557
android:exported="false".android:exported="false"for the android component doesn't need to call outside from the app.Testing