Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

feat: Update Discover Course pages by removing course path #1817

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

HamzaIsrar12
Copy link
Contributor

Description

LEARNER-9544

  • Update the course detail template through changes made in the config repository.
  • Remove the relevant code associated with the course path.

Notes

  • Remove the course/ path segment from the Course Detail Template

Testing

  • Courses on Discovery should work fine
  • Course navigation and about pages should work fine

- Update the course detail template through changes made in the config repository.
- Remove the relevant code associated with the course path.

Fixes: LEARNER-9544
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (287dbcd) 1.13% compared to head (046d90f) 1.13%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1817      +/-   ##
===========================================
- Coverage      1.13%   1.13%   -0.01%     
  Complexity      137     137              
===========================================
  Files           534     535       +1     
  Lines         25182   25188       +6     
  Branches       3038    3039       +1     
===========================================
  Hits            286     286              
- Misses        24869   24875       +6     
  Partials         27      27              
Files Changed Coverage Δ
...ile/src/main/java/org/edx/mobile/util/UrlUtil.java 0.00% <ø> (ø)
...in/java/org/edx/mobile/util/links/WebViewLink.java 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@HamzaIsrar12 HamzaIsrar12 merged commit 1c3ce13 into master Aug 28, 2023
@HamzaIsrar12 HamzaIsrar12 deleted the hamza/LEARNER-9525 branch August 28, 2023 11:00
omerhabib26 pushed a commit that referenced this pull request Sep 12, 2023
- Update the course detail template through changes made in the config repository.
- Remove the relevant code associated with the course path.

Fixes: LEARNER-9525
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants