fix: Fix iOS redundant payment error

[jawad-khan]

LEARNER-9999

⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH

• I have checked the branch to which I would like to merge.

⛔️ DEPRECATION WARNING

This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.

Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to [email protected]

Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.

Required Testing

• Before deploying this change, complete a purchase in the stage environment.
  (^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)

Description

iOS users are facing issue where they can't enroll into a course after payment. This is happening to some users because of date mismatch in iOS receipt. This fix has changed date matching attribute from 'receipt_creation_date_ms' to original_purchase_date_ms' which is the correct way to match transaction.
.

Useful information to include:

• Which edX user roles will this change impact? Common user roles are "Learner", "Course Author", "Developer", and "Operator".
• Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
• Provide links to the description of corresponding configuration changes. Remember to correctly annotate these changes.

Supporting information

Jira Ticket: https://2u-internal.atlassian.net/browse/LEARNER-9999

Testing instructions

Please provide detailed step-by-step instructions for testing this change; how did YOU test this change?

Other information

Include anything else that will help reviewers and consumers understand the change.

• Does this change depend on other changes elsewhere?
• Any special concerns or limitations? For example: deprecations, migrations, OpenEdx vs. edx.org differences, development vs. production environment differences, security, or accessibility.

[julianajlk]

LGTM assuming the receipt response will always contain original_purchase_date_ms attribute, might be worth adding try/except on parse_ios_response()

Quick question - on the tests, is there a reason you've added original_purchase_date_ms in the original_test_id purchase but not on the other 2 examples other than the fact that it uses the latest?

[jawad-khan]

@julianajlk Apple is sending this attribute with every request so its safe to assume this, otherwise its good to throw error and tell mobile client we couldn't process request successfully.

On your question, I added it in valid case because if condition will break because of product_id mismatch in other two cases.