Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Changes for compataible with pyjwt 2 #4138

Conversation

johnny77221
Copy link

@johnny77221 johnny77221 commented Feb 24, 2024

the jwt.decode function has changed since pyJwt 2, that

jwt.decode(capture_context['key_id'], verify=False) has changed to
jwt.decode(capture_context['key_id'], options={"verify_signature": False})

so this commit fixes the error while calling while pyjwt >=2 is installed

@johnny77221 johnny77221 requested a review from a team as a code owner February 24, 2024 06:58
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 24, 2024

Thanks for the pull request, @johnny77221! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@DawoudSheraz
Copy link
Contributor

@johnny77221 Can you add the context in PR description so that the reviewers can understand why the change is needed in the first place? Thanks

@DawoudSheraz DawoudSheraz reopened this Mar 15, 2024
@DawoudSheraz
Copy link
Contributor

@mphilbrick211 Hi, can this be reviewed by Axim because this is for quince fixup and not intended for 2u/main? Thanks.

@johnny77221 Please update commit message to include fix: to ensure Lint CI checks pass.

@ormsbee
Copy link

ormsbee commented Mar 20, 2024

For people who might see this in the future, this is the deprecation notice for this API call in 2.0.

https://pyjwt.readthedocs.io/en/stable/changelog.html?highlight=verify_signature#dropped-deprecated-verify-param-in-jwt-decode

The version in quince is 2.7.

@ormsbee ormsbee merged commit ab1a264 into openedx-unsupported:open-release/quince.master Mar 20, 2024
4 checks passed
@openedx-webhooks
Copy link

@johnny77221 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants