Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support casing variations for 2 letters in latin from Mongolian #44

Open
georgeslabreche opened this issue Apr 20, 2024 · 2 comments
Open
Assignees
Labels

Comments

@georgeslabreche
Copy link
Collaborator

georgeslabreche commented Apr 20, 2024

Mongolian language does not support casing variations for 2 letters in latin, e.g.:

>>> import cyrtranslit
>>> cyrtranslit.to_cyrillic("Kh", "mn")
'Х'
>>> cyrtranslit.to_cyrillic("KH", "mn")
'КH'
>>> cyrtranslit.to_cyrillic("kh", "mn")
'х'
>>> cyrtranslit.to_cyrillic("kH", "mn")
'кH'
>>> cyrtranslit.to_cyrillic("Sh", "mn")
'Ш'
>>> cyrtranslit.to_cyrillic("SH", "mn")
'СH'
>>> cyrtranslit.to_cyrillic("TS", "mn")
'ТС'
>>> cyrtranslit.to_cyrillic("Ts", "mn")
'Ц'
@georgeslabreche georgeslabreche self-assigned this Apr 20, 2024
@georgeslabreche georgeslabreche changed the title support casing variations for 2 letters in latin from Montenegrin Support casing variations for 2 letters in latin from Montenegrin Apr 20, 2024
@georgeslabreche georgeslabreche changed the title Support casing variations for 2 letters in latin from Montenegrin Support casing variations for 2 letters in latin from Mongolian Apr 21, 2024
@Serbipunk
Copy link
Contributor

Hi @georgeslabreche,

I hope you're doing well! I was wondering if there's been any progress on the bug related to mixed uppercase and lowercase casing variations? If you need any additional assistance, I’d be happy to help.

I plan to first consult with a Mongolian colleague who has experience with this grammar issue, and then I might try to tweak the code.

@georgeslabreche
Copy link
Collaborator Author

georgeslabreche commented Jun 7, 2024

Hi @Serbipunk, thank you for your interest! I went ahead and implemented a fix, here's the pull request:
https://github.com/opendatakosovo/cyrillic-transliteration/pull/45/files

You can help me by:

  1. Going over the fix and checking if all cases are covered.
  2. Instruct me on how to actually transliterate from Sh to Cyrillic. Is it Ш/ш or Щ/щ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants