Skip to content

Commit 52ae191

Browse files
change status to enum type
Signed-off-by: Vedant Mahabaleshwarkar <[email protected]>
1 parent 3e63835 commit 52ae191

File tree

4 files changed

+10
-12
lines changed

4 files changed

+10
-12
lines changed

apis/components/v1alpha1/kserve_types.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ type KserveSpec struct {
7676
type KserveCommonStatus struct {
7777
// DefaultDeploymentMode is the value of the defaultDeploymentMode field
7878
// as read from the "deploy" JSON in the inferenceservice-config ConfigMap
79-
DefaultDeploymentMode string `json:"defaultDeploymentMode,omitempty"`
80-
ServerlessAvailable bool `json:"serverlessAvailable"`
79+
DefaultDeploymentMode string `json:"defaultDeploymentMode,omitempty"`
80+
ServerlessMode operatorv1.ManagementState `json:"serverlessMode,omitempty"`
8181
}
8282

8383
// KserveStatus defines the observed state of Kserve

config/crd/bases/components.platform.opendatahub.io_kserves.yaml

+3-4
Original file line numberDiff line numberDiff line change
@@ -226,10 +226,9 @@ spec:
226226
type: integer
227227
phase:
228228
type: string
229-
serverlessAvailable:
230-
type: boolean
231-
required:
232-
- serverlessAvailable
229+
serverlessMode:
230+
pattern: ^(Managed|Unmanaged|Force|Removed)$
231+
type: string
233232
type: object
234233
type: object
235234
x-kubernetes-validations:

config/crd/bases/datasciencecluster.opendatahub.io_datascienceclusters.yaml

+3-4
Original file line numberDiff line numberDiff line change
@@ -737,10 +737,9 @@ spec:
737737
- Removed
738738
pattern: ^(Managed|Unmanaged|Force|Removed)$
739739
type: string
740-
serverlessAvailable:
741-
type: boolean
742-
required:
743-
- serverlessAvailable
740+
serverlessMode:
741+
pattern: ^(Managed|Unmanaged|Force|Removed)$
742+
type: string
744743
type: object
745744
kueue:
746745
description: Kueue component status.

controllers/components/kserve/kserve_controller_actions.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -286,9 +286,9 @@ func setStatusFields(ctx context.Context, rr *odhtypes.ReconciliationRequest) er
286286
if k.Spec.Serving.ManagementState == operatorv1.Managed || k.Spec.Serving.ManagementState == operatorv1.Unmanaged {
287287
serverlessInstalled = true
288288
}
289-
k.Status.ServerlessAvailable = false
289+
k.Status.ServerlessMode = operatorv1.Removed
290290
if serverlessInstalled && serviceMeshInstalled {
291-
k.Status.ServerlessAvailable = true
291+
k.Status.ServerlessMode = operatorv1.Managed
292292
}
293293
return nil
294294
}

0 commit comments

Comments
 (0)