Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: chore(gha): fix poetry install in GitHub Actions #744

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jiridanek
Copy link
Member

Description

Currently, pip install refuses to install outside of a virtual env without --break-system-packages.

To fix this, let's install with pipx and let's configure pipx for GHA caching.

How Has This Been Tested?

GHA

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Currently, `pip install` refuses to install outside of a virtual env
without `--break-system-packages`.

To fix this, let's install with `pipx` and let's configure pipx for GHA caching.
@openshift-ci openshift-ci bot requested review from atheo89 and harshad16 October 14, 2024 10:49
@jiridanek
Copy link
Member Author

/cc @jstourac

@openshift-ci openshift-ci bot requested a review from jstourac October 14, 2024 11:04
@jstourac
Copy link
Member

/lgtm

@jiridanek
Copy link
Member Author

/override ci/prow/images
/approve

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit e97cebb into opendatahub-io:main Oct 14, 2024
7 checks passed
@jiridanek jiridanek deleted the poetry_venv branch October 14, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants