Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated odh-elyra from 4.0.0 to 4.0.1 #726

Conversation

paulovmr
Copy link
Contributor

@paulovmr paulovmr commented Oct 3, 2024

Description

Updated odh-elyra from 4.0.0 to 4.0.1.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from caponetto and jiridanek October 3, 2024 12:37
@caponetto
Copy link
Contributor

/lgtm

@jiridanek
Copy link
Member

/lgtm

@harshad16
Copy link
Member

@paulovmr can you rebase , PR #725 was merged, so it caused conflicts on this PR.

@paulovmr paulovmr force-pushed the update-version-odh-elyra-4.0.1 branch from 3b0b230 to 3fcb275 Compare October 3, 2024 14:13
@openshift-ci openshift-ci bot removed the lgtm label Oct 3, 2024
@caponetto
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 3, 2024
@jstourac
Copy link
Member

jstourac commented Oct 3, 2024

/lgtm

@paulovmr
Copy link
Contributor Author

paulovmr commented Oct 3, 2024

/retest

1 similar comment
@paulovmr
Copy link
Contributor Author

paulovmr commented Oct 3, 2024

/retest

@harshad16
Copy link
Member

Tested the PR with:
quay.io/opendatahub/workbench-images:cuda-jupyter-tensorflow-ubi9-python-3.11-pr-726

Ran the elyra example: Ran successfully
Screenshot from 2024-10-04 01-30-51

@harshad16
Copy link
Member

/lgtm
/approve

/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

@harshad16: Overrode contexts on behalf of harshad16: ci/prow/images, ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/lgtm
/approve

/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 609ffb8 into opendatahub-io:main Oct 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants