Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Notebook with codeflare-sdk version 0.21.1 #725

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

harshad16
Copy link
Member

Description

Upgrade Notebook with codeflare-sdk version 0.21.1
Fixes: #719

As the github action failed: https://github.com/project-codeflare/codeflare-sdk/actions/runs/11134262380

How Has This Been Tested?

NA

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jiridanek
Copy link
Member

/lgtm

@jiridanek
Copy link
Member

/retest-required

@jstourac
Copy link
Member

jstourac commented Oct 3, 2024

@harshad16, are these skipped intentionally? Not touching any intel ones?

jupyter/intel/ml/ubi9-python-3.11/Pipfile:codeflare-sdk = "~=0.19.1"
jupyter/intel/pytorch/ubi9-python-3.11/Pipfile.cpu:codeflare-sdk = "~=0.13.0"
jupyter/intel/pytorch/ubi9-python-3.11/Pipfile.gpu:codeflare-sdk = "~=0.13.0"
jupyter/intel/tensorflow/ubi9-python-3.11/Pipfile.cpu:codeflare-sdk = "~=0.13.0"
jupyter/intel/tensorflow/ubi9-python-3.11/Pipfile.gpu:codeflare-sdk = "~=0.13.0"
intel/runtimes/ml/ubi9-python-3.11/Pipfile:codeflare-sdk = "~=0.19.1"
intel/runtimes/pytorch/ubi9-python-3.11/Pipfile.cpu:codeflare-sdk = "~=0.13.0"
intel/runtimes/pytorch/ubi9-python-3.11/Pipfile.gpu:codeflare-sdk = "~=0.13.0"
intel/runtimes/tensorflow/ubi9-python-3.11/Pipfile.cpu:codeflare-sdk = "~=0.13.0"
intel/runtimes/tensorflow/ubi9-python-3.11/Pipfile.gpu:codeflare-sdk = "~=0.13.0"

@harshad16
Copy link
Member Author

are these skipped intentionally? Not touching any intel ones?

yes @jstourac
currently it isn't part of our OOTB
I m leaving it out of the custom PR, lets see it later on.

@jstourac
Copy link
Member

jstourac commented Oct 3, 2024

are these skipped intentionally? Not touching any intel ones?

yes @jstourac currently it isn't part of our OOTB I m leaving it out of the custom PR, lets see it later on.

Great, thanks for confirmation, Harshad.

In that case /lgtm for this one.

As such, should we ignore python 3.9 and intel based images in the GHA from the codeflare sdk repository?

@harshad16
Copy link
Member Author

As such, should we ignore python 3.9 and intel based images in the GHA from the codeflare sdk repository?

  1. i m sure on python3.9
  2. about intel, will confirm after some discussions.

@harshad16
Copy link
Member Author

Thanks for all the review

/approve

/override ci/prow/images
/override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/rocm-runtimes-ubi9-e2e-tests
/override ci/prow/runtimes-ubi9-e2e-tests

Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

@harshad16: Overrode contexts on behalf of harshad16: ci/prow/images, ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests, ci/prow/rocm-runtimes-ubi9-e2e-tests, ci/prow/runtimes-ubi9-e2e-tests

In response to this:

Thanks for all the review

/approve

/override ci/prow/images
/override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/rocm-runtimes-ubi9-e2e-tests
/override ci/prow/runtimes-ubi9-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit dd760d5 into opendatahub-io:main Oct 3, 2024
31 checks passed
@Srihari1192
Copy link

@harshad16 Also can you include this codeflare-sdk version 0.21.1 changes to the notebook for RHOAI 2.14 release branch

@harshad16
Copy link
Member Author

@Srihari1192 all the work would be moved today to release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants