Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Server update to version 4.92.2 #723

Conversation

daniellutz
Copy link
Contributor

@daniellutz daniellutz commented Oct 2, 2024

This PR aims to update code-server and some extensions.

Jira:

Image tags:

  • podman pull quay.io/opendatahub/workbench-images:codeserver-ubi9-python-3.9-pr-723
  • podman pull quay.io/opendatahub/workbench-images:codeserver-ubi9-python-3.11-pr-723

Description

This PR aims to update, not only code-server itself, but also the builtin extensions to provide support for Python and Jupyter.

The following components have been updated:

  • The codeserver version from v4.22.0 to v4.92.2
  • The pre-built extensions
    • ms-python.python from 2024.2.1 to 2024.14.1
      • ms-python.debugpy from 2024.2.0 to 2024.8.0
    • ms-toolsai.jupyter from 2023.9.100 to 2024.7.0
      • ms-toolsai.jupyter-renderers from 1.0.17 to 1.0.19
      • ms-toolsai.vscode-jupyter-cell-tags from 0.1.8 to 0.1.9
      • ms-toolsai.vscode-jupyter-slideshow from 0.1.5 to 0.1.6

How Has This Been Tested?

This has been locally tested, which consisted on running the CodeServer image locally with the following commands:

$ export QUAY_IO=quay.io/{user}/workbench-images
$ export WORKBENCH_RELEASE=2024b
$ make codeserver-ubi9-python-3.9 \
       -e IMAGE_REGISTRY=$QUAY_IO \
       -e RELEASE=$WORKBENCH_RELEASE \
       -e PUSH_IMAGES=no \
       -e CONTAINER_BUILD_CACHE_ARGS=""

This way the image could easily be built and tested, without pushing any images to our quay repository yet.

Now you can run with Podman:

$ export LATEST_TAG=`podman images --format "{{.Repository}}:{{.Tag}}" | grep "$QUAY_IO:codeserver-ubi9-python-3.9-$WORKBENCH_RELEASE" | sort -r | head -n1 | cut -d':' -f2`
$ podman run -it -p 8787:8787 $QUAY_IO:$LATEST_TAG

From logs, we can see that the extensions have been enabled in code-server

[...]
Debug: Extension 'ms-python.debugpy-2024.11.0-dev-linux-x64' copied to runtime directory.
Debug: Extension 'ms-python.python-2024.14.1' copied to runtime directory.
Debug: Extension 'ms-toolsai.jupyter-2024.7.0' copied to runtime directory.
Debug: Extension 'ms-toolsai.jupyter-keymap-1.1.2-universal' copied to runtime directory.
Debug: Extension 'ms-toolsai.jupyter-renderers-1.0.19-universal' copied to runtime directory.
Debug: Extension 'ms-toolsai.vscode-jupyter-cell-tags-0.1.9-universal' copied to runtime directory.
Debug: Extension 'ms-toolsai.vscode-jupyter-slideshow-0.1.6-universal' copied to runtime directory.
[...]
[2024-10-03T13:53:18.388Z] info  HTTP server listening on http://0.0.0.0:8787/
[2024-10-03T13:53:18.389Z] info    - Authentication is disabled
[2024-10-03T13:53:18.389Z] info    - Not serving HTTPS
[...]

When opening now code-server via http://0.0.0.0:8787/, you can try to run a snippet in Python, as follows:

local-test-code-server-update

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@daniellutz daniellutz self-assigned this Oct 3, 2024
@daniellutz daniellutz marked this pull request as ready for review October 3, 2024 14:27
@openshift-ci openshift-ci bot requested review from jiridanek and paulovmr October 3, 2024 14:27
- Fix codeserver extension typo
- Update Code Server to version 4.92.2
- Add instructions to run Code Server containers and how to update extensions
- Minor change in extensions README instructions
- Update extensions and add instructions on how to update extensions in the repository
@daniellutz daniellutz changed the title Code server update 4.92.2 Code Server update to version 4.92.2 Oct 3, 2024
@daniellutz daniellutz force-pushed the code-server-update-4.92.2 branch from a506384 to 002fd53 Compare October 3, 2024 14:48
@harshad16
Copy link
Member

tested the Pr image on cluster
Screenshot from 2024-10-03 13-44-45

Thanks for the work.
only python 3.11 change would be used in 2024b images.

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16
Copy link
Member

/override ci/prow/codeserver-notebook-e2e-tests
/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

@harshad16: Overrode contexts on behalf of harshad16: ci/prow/codeserver-notebook-e2e-tests, ci/prow/images

In response to this:

/override ci/prow/codeserver-notebook-e2e-tests
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 2b77e1c into opendatahub-io:main Oct 3, 2024
21 checks passed
@@ -0,0 +1,20 @@
# codeserver-ubi9-python-3.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick:

codeserver-ubi9-python-3.9

@jstourac
Copy link
Member

jstourac commented Oct 4, 2024

Good job this PR @daniellutz, thanks!

@daniellutz daniellutz deleted the code-server-update-4.92.2 branch October 4, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants