Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the notebook manifests with 2024b image reference #721

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Updated the notebook manifests with 2024b image reference #721

merged 1 commit into from
Oct 4, 2024

Conversation

dibryant
Copy link
Contributor

@dibryant dibryant commented Oct 1, 2024

fixes for https://issues.redhat.com/browse/RHOAIENG-12628

Description

Updated the notebook manifests with 2024b and 2024a image reference

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from jstourac and paulovmr October 1, 2024 13:39
harshad16
harshad16 requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all great
just one question, can we have change of version for rstudio as well

manifests/base/rstudio-notebook-imagestream.yaml Show resolved Hide resolved
@dibryant dibryant force-pushed the manifest branch 2 times, most recently from 22ae3dd to 68ea439 Compare October 3, 2024 17:55
harshad16
harshad16 requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes
some additional changes:

harshad16
harshad16 requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more changes needed

manifests/base/jupyter-datascience-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/base/jupyter-datascience-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/base/rstudio-notebook-imagestream.yaml Outdated Show resolved Hide resolved
atheo89
atheo89 requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Diamond, added a couple of comments

manifests/base/jupyter-datascience-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/base/jupyter-datascience-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/base/jupyter-pytorch-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/base/jupyter-rocm-minimal-notebook-imagestream.yaml Show resolved Hide resolved
manifests/base/jupyter-rocm-tensorflow-notebook-imagestream.yaml Show resolved Hide resolved
manifests/base/jupyter-tensorflow-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/base/jupyter-trustyai-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/base/rstudio-gpu-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/base/rstudio-gpu-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/base/rstudio-notebook-imagestream.yaml Outdated Show resolved Hide resolved
@atheo89 atheo89 mentioned this pull request Oct 4, 2024
Merged
harshad16
harshad16 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks for all the work.

@openshift-ci openshift-ci bot added the lgtm label Oct 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
@harshad16
Copy link
Member

Merging to move a head.

@harshad16 harshad16 merged commit bebc11e into opendatahub-io:main Oct 4, 2024
16 of 18 checks passed
@jstourac jstourac mentioned this pull request Oct 11, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheo89 atheo89 atheo89 requested changes

@harshad16 harshad16 harshad16 approved these changes

@jstourac jstourac Awaiting requested review from jstourac

@paulovmr paulovmr Awaiting requested review from paulovmr

Assignees

@harshad16 harshad16

@atheo89 atheo89

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dibryant @harshad16 @jstourac @atheo89