hot-fix: set the workbench-image-recommended anno to false for 2023.1 #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshad Reddy Nalla <[email protected]>
jstourac
approved these changes
Nov 28, 2023
as we never had that annotation for that tag, including it would be necessary. |
harshad16
commented
Nov 28, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16, jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
atheo89
pushed a commit
to atheo89/notebooks
that referenced
this pull request
Oct 23, 2024
…atahub-io#376) This change updates the Habana image used for the 2.10.z stream release with the bunch of updated packages where the main thing is update of the jupyter-server-proxy package [1]. * [1] https://issues.redhat.com/browse/RHOAIENG-11695 Co-authored-by: Harshad Reddy Nalla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set the workbench-image-recommended anno to false for 2023.1
Description
Related-to: #373
In ODH 2.2 upgrade to 2.4 + version, the recommend-tag annotation shows up for 2023.2 and 2023.1.
The 2023.1 would not have the recommended tag with the annotation set to false.
How Has This Been Tested?
Merge criteria: