Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we implement filtering to avoid building images for certain file types, such as *.md or *.yaml? Probably as future enhancement #581

Closed
jiridanek opened this issue Jun 21, 2024 · 2 comments

Comments

@jiridanek
Copy link
Member

          Can we implement filtering to avoid building images for certain file types, such as *.md or *.yaml? Probably as future enhancement

🤔 This idea came to me when I opened this PR:: #573

Originally posted by @atheo89 in #558 (comment)

@jiridanek
Copy link
Member Author

This should probably check the .dockerignore file and skip building if only ignored files in the directory have changed. Some people put the Dockerfile itself into .dockerignore, so there must be special provision not to skip changes in Dockerfile. Changes in .dockerignore can be ignored as well, I suppose.

@jiridanek
Copy link
Member Author

Closing this as Won't Do, see justification at

@jiridanek jiridanek closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅Done in ODH IDE Planning Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant