Skip to content

Commit

Permalink
Fix #713: gha: don't crash when branch name matches file name in the …
Browse files Browse the repository at this point in the history
…repo
  • Loading branch information
jiridanek committed Sep 26, 2024
1 parent 22e395c commit e7890d6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion ci/cached-builds/gha_pr_changed_files.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ def get_github_token() -> str:
def list_changed_files(from_ref: str, to_ref: str) -> list[str]:
logging.debug("Getting list of changed files from git diff")

files = subprocess.check_output(["git", "diff", "--name-only", from_ref, to_ref],
# https://github.com/red-hat-data-services/notebooks/pull/361: add -- in case to_ref matches a file name in the repo
files = subprocess.check_output(["git", "diff", "--name-only", from_ref, to_ref, '--'],
encoding='utf-8').splitlines()

logging.debug(f"Determined {len(files)} changed files: {files[:100]} (..., printing up to 100 files)")
Expand Down

0 comments on commit e7890d6

Please sign in to comment.