Skip to content

Commit

Permalink
fixup, the ifNotPresent pull policy (for PR checks without image regi…
Browse files Browse the repository at this point in the history
…stry) and the symbolic links apparently needed to deploy rocm stuff
  • Loading branch information
jiridanek committed Nov 28, 2024
1 parent 90ffad7 commit 0040db8
Showing 1 changed file with 20 additions and 0 deletions.
20 changes: 20 additions & 0 deletions .github/workflows/build-notebooks-TEMPLATE.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,26 @@ jobs:
id: have-tests
run: "ci/cached-builds/has_tests.py --target ${{ inputs.target }}"

- name: "Change pull policy to IfNotPresent"
run: |
set -Eeuxo pipefail
find . \( -name "statefulset.yaml" -o -name "pod.yaml" \) -type f -exec \
sed -i'' 's/imagePullPolicy: Always/imagePullPolicy: IfNotPresent/g' {} \;
git diff
# [INFO] Running command (('make deploy9-runtimes-rocm-tensorflow-ubi9-python-3.11',), {'shell': True})
# Deploying notebook from runtimes/rocm/tensorflow/ubi9-python-3.11/kustomize/base directory...
# sed: can't read runtimes/rocm/tensorflow/ubi9-python-3.11/kustomize/base/kustomization.yaml: No such file or directory
- name: "Fixup paths that prevent us from running rocm tests"
if: ${{ steps.have-tests.outputs.tests == 'true' }}
run: |
set -Eeuxo pipefail
mkdir -p runtimes/rocm
ln -s ../rocm-tensorflow runtimes/rocm/tensorflow
ln -s ../rocm-pytorch runtimes/rocm/pytorch
# https://cri-o.io/
- name: Install cri-o
if: ${{ steps.have-tests.outputs.tests == 'true' }}
Expand Down

0 comments on commit 0040db8

Please sign in to comment.