Skip to content

Commit 28b0611

Browse files
committed
removal of pull secret
Signed-off-by: Ryan Cook <[email protected]>
1 parent fb4a70a commit 28b0611

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

pipeline.py

-8
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
DeletePVC,
1111
mount_pvc,
1212
set_image_pull_policy,
13-
set_image_pull_secrets,
1413
use_config_map_as_env,
1514
use_secret_as_env,
1615
use_secret_as_volume,
@@ -23,7 +22,6 @@
2322
MOCKED_STAGES = ["sdg", "train", "eval"]
2423
PIPELINE_FILE_NAME = "pipeline.yaml"
2524
IMPORTER_PIPELINE_FILE_NAME = "importer-pipeline.yaml"
26-
IMAGE_PULL_SECRET = ""
2725
STANDALONE_TEMPLATE_FILE_NAME = "standalone.tpl"
2826
GENERATED_STANDALONE_FILE_NAME = "standalone.py"
2927
DEFAULT_REPO_URL = "https://github.com/instructlab/taxonomy.git"
@@ -213,8 +211,6 @@ def pipeline(
213211
mount_path="/data",
214212
)
215213

216-
set_image_pull_secrets(sdg_task, [IMAGE_PULL_SECRET])
217-
218214
# uncomment if updating image with same tag
219215
# set_image_pull_policy(sdg_task, "Always")
220216

@@ -252,8 +248,6 @@ def pipeline(
252248
data_processing_task.set_caching_options(False)
253249
data_processing_task.set_env_variable("XDG_CACHE_HOME", "/tmp")
254250

255-
set_image_pull_secrets(data_processing_task, [IMAGE_PULL_SECRET])
256-
257251
# Upload "skills_processed_data" and "knowledge_processed_data" artifacts to S3 without blocking the rest of the workflow
258252
skills_processed_data_to_artifact_task = skills_processed_data_to_artifact_op()
259253
skills_processed_data_to_artifact_task.after(data_processing_task)
@@ -353,7 +347,6 @@ def pipeline(
353347
JUDGE_CONFIG_MAP,
354348
dict(endpoint="JUDGE_ENDPOINT", model="JUDGE_NAME"),
355349
)
356-
set_image_pull_secrets(run_mt_bench_task, [IMAGE_PULL_SECRET])
357350
use_secret_as_env(run_mt_bench_task, JUDGE_SECRET, {"api_key": "JUDGE_API_KEY"})
358351

359352
# uncomment if updating image with same tag
@@ -392,7 +385,6 @@ def pipeline(
392385

393386
final_eval_task.set_env_variable("HOME", "/tmp")
394387
final_eval_task.set_env_variable("HF_HOME", "/tmp")
395-
set_image_pull_secrets(final_eval_task, [IMAGE_PULL_SECRET])
396388

397389
# uncomment if updating image with same tag
398390
# set_image_pull_policy(final_eval_task, "Always")

pipeline.yaml

-8
Original file line numberDiff line numberDiff line change
@@ -2241,8 +2241,6 @@ platforms:
22412241
deploymentSpec:
22422242
executors:
22432243
exec-data-processing-op:
2244-
imagePullSecret:
2245-
- {}
22462244
pvcMount:
22472245
- mountPath: /model
22482246
taskOutputParameter:
@@ -2296,8 +2294,6 @@ platforms:
22962294
envVar: JUDGE_ENDPOINT
22972295
- configMapKey: model
22982296
envVar: JUDGE_NAME
2299-
imagePullSecret:
2300-
- {}
23012297
pvcMount:
23022298
- mountPath: /output
23032299
taskOutputParameter:
@@ -2324,8 +2320,6 @@ platforms:
23242320
envVar: JUDGE_ENDPOINT
23252321
- configMapKey: model
23262322
envVar: JUDGE_NAME
2327-
imagePullSecret:
2328-
- {}
23292323
pvcMount:
23302324
- mountPath: /output
23312325
taskOutputParameter:
@@ -2344,8 +2338,6 @@ platforms:
23442338
envVar: endpoint
23452339
- configMapKey: model
23462340
envVar: model
2347-
imagePullSecret:
2348-
- {}
23492341
pvcMount:
23502342
- mountPath: /data
23512343
taskOutputParameter:

0 commit comments

Comments
 (0)