Skip to content

Commit 59cbb02

Browse files
committed
No need for WoA-specific scripts.
All we needed in the end was to use the arm64 version of Node.js!
1 parent 092f21c commit 59cbb02

File tree

4 files changed

+6
-31
lines changed

4 files changed

+6
-31
lines changed

.github/workflows/cd.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,12 @@ jobs:
1919
- name: Windows (ARM)
2020
os: windows-2019
2121
node_architecture: arm64
22-
install_suffix: ':arm'
23-
package_suffix: ':arm'
2422
- name: Linux (Intel)
2523
os: ubuntu-22.04
2624
node_architecture: x64
2725
- name: Linux (ARM)
2826
os: ubuntu-22.04-arm
2927
node_architecture: arm64
30-
install_suffix: ':arm'
3128
- name: macOS (Intel)
3229
os: macos-13
3330
node_architecture: x64
@@ -79,9 +76,9 @@ jobs:
7976
sudo apt update
8077
sudo apt install libopenjp2-tools
8178
- name: OpenCOR dependencies
82-
run: pnpm install${{ matrix.install_suffix }}
79+
run: pnpm install
8380
- name: Package OpenCOR
84-
run: pnpm package${{ matrix.package_suffix }}
81+
run: pnpm package
8582
- name: Remove blockmap files
8683
shell: bash
8784
run: find ./dist -name '*.blockmap' -delete

.github/workflows/ci.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,12 @@ jobs:
1919
- name: Windows (ARM)
2020
os: windows-2019
2121
node_architecture: arm64
22-
install_suffix: ':arm'
23-
build_suffix: ':arm'
2422
- name: Linux (Intel)
2523
os: ubuntu-22.04
2624
node_architecture: x64
2725
- name: Linux (ARM)
2826
os: ubuntu-22.04-arm
2927
node_architecture: arm64
30-
install_suffix: ':arm'
3128
- name: macOS (Intel)
3229
os: macos-13
3330
node_architecture: x64
@@ -53,10 +50,10 @@ jobs:
5350
- name: Install pnpm
5451
run: npm install -g pnpm
5552
- name: OpenCOR dependencies
56-
run: pnpm install${{ matrix.install_suffix }}
53+
run: pnpm install
5754
- name: Build OpenCOR
5855
if: ${{ (matrix.name != 'Code formatting') && (matrix.name != 'Linting') }}
59-
run: pnpm build${{ matrix.build_suffix }}
56+
run: pnpm build
6057
- name: Build OpenCOR's Web app
6158
if: ${{ (matrix.name != 'Code formatting') && (matrix.name != 'Linting') }}
6259
run: pnpm build:web

README.md

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ To build OpenCOR, you also need a C/C++ toolchain:
3232

3333
## Scripts
3434

35-
Before doing anything, you need to install all of OpenCOR's dependencies (see the [note](#note) below regarding the optional `:arm` suffix):
35+
Before doing anything, you need to install all of OpenCOR's dependencies:
3636

3737
```bash
38-
pnpm install[:arm]
38+
pnpm install
3939
```
4040

4141
Then, you can run a given script:
@@ -47,27 +47,15 @@ pnpm <script>
4747
where `<script>` is one of the following:
4848

4949
- `build`: build OpenCOR;
50-
- `build:arm`: build OpenCOR for [Windows](https://en.wikipedia.org/wiki/Microsoft_Windows) on [ARM](https://en.wikipedia.org/wiki/ARM_architecture_family);
5150
- `build:libopencor`: build OpenCOR's JavaScript interface to the C++ bindings of libOpenCOR;
52-
- `build:libopencor:arm`: build OpenCOR's JavaScript interface to the C++ bindings of libOpenCOR for [Windows](https://en.wikipedia.org/wiki/Microsoft_Windows) on [ARM](https://en.wikipedia.org/wiki/ARM_architecture_family);
5351
- `build:web`: build OpenCOR's Web app;
5452
- `clean`: clean OpenCOR's environment;
55-
- `clean:all`: clean OpenCOR's environment and then prune `pnpm`'s store (the latter is needed when wanting to use both the `install` and `install:arm` scripts);
5653
- `dev`: start OpenCOR and OpenCOR's Web app in development mode;
57-
- `dev:arm`: start OpenCOR for [Windows](https://en.wikipedia.org/wiki/Microsoft_Windows) on [ARM](https://en.wikipedia.org/wiki/ARM_architecture_family) and OpenCOR's Web app in development mode;
5854
- `dev:web`: start OpenCOR's Web app in development mode;
5955
- `format`: format OpenCOR's code and OpenCOR's Web app's code;
6056
- `format:check`: check that OpenCOR's code and OpenCOR's Web app's code are properly formatted;
61-
- `install`: install OpenCOR's dependencies;
62-
- `install:arm`: install OpenCOR's dependencies for [Windows](https://en.wikipedia.org/wiki/Microsoft_Windows)/[Linux](https://en.wikipedia.org/wiki/Linux) on [ARM](https://en.wikipedia.org/wiki/ARM_architecture_family);
6357
- `lint`: lint OpenCOR's code and OpenCOR's Web app's code;
6458
- `package`: (build and) package OpenCOR for the current platform;
65-
- `package:arm`: (build and) package OpenCOR for [Windows](https://en.wikipedia.org/wiki/Microsoft_Windows) on [ARM](https://en.wikipedia.org/wiki/ARM_architecture_family) for the current platform;
6659
- `publish:web`: publish OpenCOR's Web app on [npm](https://npmjs.com/);
6760
- `start`: start OpenCOR in production mode; and
68-
- `start:arm`: start OpenCOR for [Windows](https://en.wikipedia.org/wiki/Microsoft_Windows) on [ARM](https://en.wikipedia.org/wiki/ARM_architecture_family) in production mode; and
6961
- `start:web`: start OpenCOR's Web app in production mode.
70-
71-
<a name="note" ></a>
72-
73-
**Note:** scripts that have an `:arm` suffix are only to be used when wanting to target [Windows](https://en.wikipedia.org/wiki/Microsoft_Windows) on [ARM](https://en.wikipedia.org/wiki/ARM_architecture_family) or installing on [Linux](https://en.wikipedia.org/wiki/Linux) on [ARM](https://en.wikipedia.org/wiki/ARM_architecture_family). The corresponding generic scripts only target [Windows](https://en.wikipedia.org/wiki/Microsoft_Windows) on [Intel](https://en.wikipedia.org/wiki/List_of_Intel_processors) (and [Linux](https://en.wikipedia.org/wiki/Linux)/[macOS](https://en.wikipedia.org/wiki/MacOS) on [Intel](https://en.wikipedia.org/wiki/List_of_Intel_processors)/[ARM](https://en.wikipedia.org/wiki/ARM_architecture_family), depending on the operating system and on the C/C++ toolchain).

package.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,24 +32,17 @@
3232
},
3333
"scripts": {
3434
"build": "pnpm build:libopencor && electron-vite build",
35-
"build:arm": "pnpm build:libopencor:arm && electron-vite build",
3635
"build:libopencor": "cmake-js build -B Release -O out/libOpenCOR",
37-
"build:libopencor:arm": "cmake-js build -a arm64 -B Release -O out/libOpenCOR",
3836
"build:web": "cd ./src/renderer && vite build",
3937
"clean": "node res/clean.js",
40-
"clean:all": "pnpm clean && pnpm store prune",
4138
"dev": "pnpm build:libopencor && electron-vite dev --watch",
42-
"dev:arm": "pnpm build:libopencor:arm && electron-vite dev --watch",
4339
"dev:web": "cd ./src/renderer && vite dev",
4440
"format": "prettier --log-level silent --write . && clang-format -i src/libopencor/src/*",
4541
"format:check": "prettier --log-level silent --check . && clang-format --dry-run -Werror src/libopencor/src/*",
46-
"install:arm": "pnpm install --config.target_arch=arm64",
4742
"lint": "eslint --fix .",
4843
"package": "pnpm build && electron-builder",
49-
"package:arm": "pnpm build:arm && electron-builder --arm64",
5044
"publish:web": "pnpm publish ./src/renderer",
5145
"start": "pnpm build:libopencor && electron-vite preview",
52-
"start:arm": "pnpm build:libopencor:arm && electron-vite preview",
5346
"start:web": "pnpm build:web && cd ./src/renderer && vite preview"
5447
},
5548
"devDependencies": {

0 commit comments

Comments
 (0)