Tests: make sure that our failing simulation test passes.

Author: agarny

src/sed/sedinstance.cpp

@@ -74,6 +74,10 @@ SedInstance::Impl::Impl(const SedDocumentPtr &pDocument)
 
 double SedInstance::Impl::run()
 {
+    // Reset iourselves.
+
+    removeAllIssues();
+
     // Run all the tasks associated with this instance unless they have some issues.
 
     auto res = 0.0;
@@ -84,6 +88,10 @@ double SedInstance::Impl::run()
 
             if (task->hasIssues()) {
                 addIssues(task);
+
+                // Reset the issues of the task so that they are not reported again should the instance be run again.
+
+                task->pimpl()->removeAllIssues();
             }
         }
     }

tests/misc/failingsimulationtests.cpp

@@ -26,8 +26,7 @@ TEST(FailingSimulationTest, basic)
     auto document = libOpenCOR::SedDocument::create(file);
     auto instance = document->instantiate();
 
-    instance->run();
-
+    EXPECT_NE(instance->run(), 0.0);
     EXPECT_FALSE(instance->hasIssues());
 
     // Set the value of `membrane.test` to zero and rerun the simulation.
@@ -36,15 +35,13 @@ TEST(FailingSimulationTest, basic)
 
     model->addChange(libOpenCOR::SedChangeAttribute::create("membrane", "test", "0.0"));
 
-    instance->run();
-
+    EXPECT_EQ(instance->run(), 0.0);
     EXPECT_TRUE(instance->hasIssues());
 
     // Remove all changes and rerun the simulation.
 
     model->removeAllChanges();
 
-    instance->run();
-
+    EXPECT_NE(instance->run(), 0.0);
     EXPECT_FALSE(instance->hasIssues());
 }