Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testregistry incomplete/inconsistent data #3439

Open
MarcCharlebois opened this issue Sep 18, 2024 · 1 comment
Open

testregistry incomplete/inconsistent data #3439

MarcCharlebois opened this issue Sep 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@MarcCharlebois
Copy link
Contributor

Describe the bug
testregistry incomplete and inconsistent data

To Reproduce
N/A

Expected behavior
N/A

Logs
N/A

Network device platform (please complete the following information):
N/A

Additional context
Looking at the proto for testregistry - there seem to be some inconsistencies with the current values populated and the proto. Please see below examples.

  • Authz-1 Doesn't follow the the regex listed (not sure if the regex should be adapted to fit the tests more loosely, or if the test IDs should be restricted to the regex).
    // id -- Test ID, required, must be unique, must match the regex:
    // [A-Z][A-Z]+\-[0-9]+(\.[0-9]+)?
    // Test ID should match the rundata.TestPlanID of the linked exec.
    // For example: AA-1.1

  • Certain test IDs are repeated in the description (shouldn't be necessary if the we already have the ID)
    id: "RT-7.6"
    description: "RT-7.6: BGP Link Bandwidth Community - Aggregation"
  • Do we expect each test to be fully populated with Description, ID, Readme, Exec?
@MarcCharlebois MarcCharlebois added the bug Something isn't working label Sep 18, 2024
@dplore
Copy link
Member

dplore commented Sep 19, 2024

Yes, we want testregistry to provide an id, description and link to the relevant README.

I've created an internal tracking issue to add a CI check (and a generator for testregistry) to resolve these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants