Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate code for scheduling #221

Open
Arnei opened this issue Nov 3, 2023 · 0 comments · May be fixed by #911
Open

Duplicate code for scheduling #221

Arnei opened this issue Nov 3, 2023 · 0 comments · May be fixed by #911
Labels
type:code-enhancement Internal improvements to the codebase

Comments

@Arnei
Copy link
Member

Arnei commented Nov 3, 2023

The scheduling tabs for new events and existing events have quite a bit of overlap in what they do, but seem to largely each use their own code for it. So there is probably a fair bit of duplicate code in/app/src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx and /app/src/components/events/partials/ModalTabsAndPages/EventDetailsSchedulingTab.tsx, as well as related files, that we could get rid of.
@Arnei Arnei added the type:code-enhancement Internal improvements to the codebase label Nov 3, 2023
@Arnei Arnei linked a pull request Sep 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:code-enhancement Internal improvements to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify Scheduling pages Arnei/opencast-admin-interface
1 participant
@Arnei